Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338214 - Provide API for resolveChunkSize in CDOCollectionLoadingPolicy interface
Summary: Provide API for resolveChunkSize in CDOCollectionLoadingPolicy interface
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Eike Stepper CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-25 08:05 EST by Frieder Jacobi CLA
Modified: 2011-06-23 03:38 EDT (History)
0 users

See Also:

Attachments
pulling method "getResolveChunkSize" up to interface definition (823 bytes, patch)
2011-02-25 08:07 EST, Frieder Jacobi CLA 		stepper: iplog+
Details | Diff
Patch v2 (922 bytes, patch)
2011-02-25 10:39 EST, Eike Stepper CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frieder Jacobi CLA 2011-02-25 08:05:27 EST 
Build Identifier: M20100909-0800

The interface CDOCollectionLoadingPolicy does not provide the method getResolveChunkSize, although this feature logically seems to be part of its definition (see http://wiki.eclipse.org/CDO/Tweaking_Performance#Loading_Partial_Collections_.E2.80.93_CDOCollectionLoadingPolicy and org.eclipse.emf.internal.cdo.session.CDOCollectionLoadingPolicyImpl).


Reproducible: Always

Steps to Reproduce:
1. see source code
Comment 1 Frieder Jacobi CLA 2011-02-25 08:07:16 EST 
Created attachment 189792 [details]
pulling method "getResolveChunkSize" up to interface definition
Comment 2 Eike Stepper CLA 2011-02-25 10:39:07 EST 
Hi Frieder, I don't quite understand this. Your new method is not called by the framework, so why shold it be there?
Comment 3 Eike Stepper CLA 2011-02-25 10:39:58 EST 
Created attachment 189815 [details]
Patch v2

Patch in workspace relativ format and with the missing @since tag.
Comment 4 Frieder Jacobi CLA 2011-02-25 13:08:01 EST 
Hello Eike, you're right - I have been trying things for which I needed this method to be in the interface, but the framework does not call it, indeed. My bad :|

But, anyhow, it makes sense to me to make this information public, since providing a size for initial chunks consequently needs a size of chunks to be resolved, am I wrong? (Keeping in mind the initial/resolve semantics of CDOCollecionLoadingPolicy, IDs vs. revisions.)
Comment 5 Eike Stepper CLA 2011-03-01 02:49:00 EST 
Added JavaDoc.
Comment 6 Eike Stepper CLA 2011-03-01 02:49:46 EST 
Committed revision 7310 to trunk.

Frieder, please confirm that:

1) The number of lines that you changed is smaller than 250.
2) You are the only author of these changed lines.
3) You apply the EPL to these changed lines.
Comment 7 Frieder Jacobi CLA 2011-03-01 04:54:10 EST 
(In reply to comment #6)
> Committed revision 7310 to trunk.
> 
> Frieder, please confirm that:
> 
> 1) The number of lines that you changed is smaller than 250.
yes.

> 2) You are the only author of these changed lines.
yes.

> 3) You apply the EPL to these changed lines.
yes.

Thank you.
Comment 8 Eike Stepper CLA 2011-03-01 05:01:03 EST 
Comment on attachment 189792 [details]
pulling method "getResolveChunkSize" up to interface definition

Thank *you* ;-)
Comment 9 Eike Stepper CLA 2011-06-23 03:38:50 EDT 
Available in R20110608-1407