Community
Participate
Working Groups
Build Identifier: 7.0.1 The Hyperlink action on a C element is called "Open Declaration". Since we are adding other kinds of "Open Declaration" hyperlinks it would be good if the original action would be called "Open C/C++ Declaration" so that it is unambiguous. Reproducible: Always Steps to Reproduce: See details
Created attachment 189777 [details] Properties files with the changed action name
Please attach a patch. What other hyperlinks are added? Could you refer to the bugs?
(In reply to comment #2) > Please attach a patch. > What other hyperlinks are added? Could you refer to the bugs? In our use case, code generation is done. And then the real declaration of a variable is not contained in src code but in an xml file. Therefore the hyperlink "Open Declaration" is confusing the user. "Open C/C++ Declaration" is unambiguous. I will provide a patch soon.
Created attachment 194465 [details] The patched properties file that contains the action labels
I'm not sure this is the right thing to do. We'll add more hyperlinks in the future (I have 2 in progress). Should we add 'C/C++' to them too? So they would be "Open C/C++ Return Type", "Open C/C++ Implementation", "Open C/C++ Declared Type", etc. It seems redundant and inconsistent with JDT's hyperlinks. Would you consider naming your hyperlink "Open XML Declaration", "Open Generating Declaration" or something different? It seems wrong to me to change the 'default' names of the hyperlinks (from JDT) to accommodate your specific use case.
I can understand your point that it is not the JDTs way. But unfortunately Java development is not C development, so applying the same concepts(ideas may not be appropriate in all use cases. The main point is: Renaming the hyperlinks does not cost much time and it will also not confuse existing users (my guess) but doing so will help our users and will spare my time since otherwise I would have to patch the plugins all the time we switch to a new version ;) What do you think? Greets Marko
Your patch not only changes the hyperlink, but also the context menu item and we would end up pretty inconsistent: E.g. Open Declaration in the Navigate menu, but Open C/C++ Declaration in the editor context menu. BTW, no other navigate command has "C/C++" in it is name. So, that's certainly not acceptable. I agree with Marc-Andre that you should rather consider to choose unambiguous names for your custom hyperlinks.
If the only problem is to spend effort to change all relevant places consistently then I can provide a proper patch for that. Would that be ok for you?
(In reply to comment #8) > If the only problem is to spend effort to change all relevant places > consistently then I can provide a proper patch for that. Would that be ok for > you? No, that's not the problem. We cannot change the UI all over the place just to make some custom contribution unambiguous.
Ok, I can understand your point. Then I guess we can close/reject this issue and I will find another way to satisfy our users ;)
Thanks for your understanding.
(In reply to comment #11) > Thanks for your understanding. No prob
