Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338148 - p2 product publisher does not rewrite important Info.plist values
Summary: p2 product publisher does not rewrite important Info.plist values
Status: CLOSED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331974
  Show dependency tree
 
Reported: 2011-02-24 14:40 EST by Brian de Alwis CLA
Modified: 2011-06-11 00:34 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian de Alwis CLA 2011-02-24 14:40:54 EST 
Build: 3.6 and beyond

The p2 product publisher is not rewriting some of the important values in the Info.plist when publishing a product for MacOS X.  These fields are notably:

   CFBundleIdentifier
   CFBundleVersion
   CFBundleShortVersionString

The CFBundleIdentifier and CFBundleVersion are used by the MacOS X's package installer to find and upgrade previous versions of an app.  As a result, installing an RCP app will over-write any matching existing RCP apps or Eclipse installs!

Ideally other fields should be set as pulled from the .product file, or there should be a way to reference a suitably populated Info.plist file.

[1] http://developer.apple.com/library/mac/#documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/TP40009249-SW1
Comment 1 Brian de Alwis CLA 2011-02-24 15:09:47 EST 
A fix has been committed to the publisher in the p2 incubator.
Comment 2 Pascal Rapicault CLA 2011-06-11 00:34:03 EDT 
Closing as fixed since the incubator got merged.
Brian if this is not the case, please reopen.