Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338111 - Separate the HTML validator into the org.eclipse.wst.html.core bundle so it can be used in headless tools
Summary: Separate the HTML validator into the org.eclipse.wst.html.core bundle so it c...
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.html (show other bugs)
Version: 3.2.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Troy Bishop CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard:
Keywords: plan
: 305914 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-24 11:08 EST by Troy Bishop CLA
Modified: 2012-07-17 12:39 EDT (History)
1 user (show)

See Also:
nsand.dev: review+

Attachments
possible patch (108.03 KB, patch)
2011-02-24 11:09 EST, Troy Bishop CLA 		nsand.dev: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Troy Bishop CLA 2011-02-24 11:08:55 EST 
Build Identifier: WTP 3.2

The HTML validator currently resides in the org.eclipse.wst.html.ui bundle which has UI dependencies and therefore cannot be packaged in headless tools.  Attached is a patch which separates the HTML validator code to org.eclipse.wst.html.core and also ensures that the "as-you-type" validation stays in the org.eclipse.wst.html.ui bundle.

Reproducible: Always
Comment 1 Troy Bishop CLA 2011-02-24 11:09:14 EST 
Created attachment 189708 [details]
possible patch
Comment 2 Nick Sandonato CLA 2011-03-07 10:37:22 EST 
Thanks for the patch, Troy. I'll take a look.
Comment 3 Nick Sandonato CLA 2011-05-12 15:53:02 EDT 
*** Bug 305914 has been marked as a duplicate of this bug. ***
Comment 4 Nick Sandonato CLA 2011-11-09 16:39:52 EST 
Patch looks good to me. Thanks, Troy! I've committed the changes to HEAD.
Comment 5 Juris Sudmalis CLA 2012-07-17 04:46:34 EDT 
See Bug 385195 for a bug possibly caused by this change.
Apparently sometimes just reading the patch isn't enough.

P.S. keep the discussion in that bug topic, not here.
Comment 6 Nitin Dahyabhai CLA 2012-07-17 12:39:32 EDT 
They why comment here?  The validator class itself has never been API, nor will it ever be API.