Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338092 - ProxyServlet leaks memory
Summary: ProxyServlet leaks memory
Status: RESOLVED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: server (show other bugs)
Version: 7.3.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 7.3.x   Edit
Assignee: Simone Bordet CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-24 09:36 EST by Simone Bordet CLA
Modified: 2014-03-26 08:08 EDT (History)
2 users (show)

See Also:

Attachments
MAT png#1 (29.83 KB, image/png)
2014-03-25 11:47 EDT, Andrew Brown CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simone Bordet CLA 2011-02-24 09:36:10 EST 
ProxyServlet uses internally an instance of HttpClient, started in init() but never stopped.
HttpClient in turn creates/uses a thread pool, which by default instantiates minThreads at startup.
On redeploy of the ProxyServlet, the HttpClient is not stopped, and its thread pool, while not referenced anymore, will leak the threads it started.
Comment 1 Simone Bordet CLA 2011-02-24 10:03:53 EST 
Fixed by stopping the HttpClient instance in ProxyServlet.destroy().
Comment 2 Andrew Brown CLA 2014-03-25 11:47:58 EDT 
Created attachment 241230 [details]
MAT png#1
Comment 3 Simone Bordet CLA 2014-03-26 06:30:41 EDT 
Andrew, you attached the MAT image, but this bug has been already fixed 3 years ago.

Can you please detail if you still have a problem ?
If so, please reopen the bug.

Which exact version of Jetty are you using ?

Can you reproduce it in a test case ?
Comment 4 Andrew Brown CLA 2014-03-26 08:08:45 EDT 
Sorry, brain failure on my part. I was browsing related bugs to the one I was going to enter to see if mine had already been reported and accidentally uploaded an attachment to this one instead of the one I was entering myself. I could not figure out a way to delete it afterwards.

The real bug that I entered is #431131