Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338078 - [patch] Request for option to not automatically add additional fragments and dependencies when launching from features
Summary: [patch] Request for option to not automatically add additional fragments and ...
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 328515 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-24 08:00 EST by Rune Glerup CLA
Modified: 2019-09-24 13:59 EDT (History)
2 users (show)

See Also:


Attachments
Suggested patch that implements the proposed feature (9.19 KB, patch)
2011-02-24 08:01 EST, Rune Glerup CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rune Glerup CLA 2011-02-24 08:00:53 EST
Build Identifier: 

When launching using a set of features PDE will automatically add additional dependencies (plug-ins or fragments) from the target platform or workspace. Even if these are not included in the selected features.

To better reflect how a packed version of the application will be launched, we would like the option to disable this behavior of automatically pulling in additional plug-ins and fragments from the workspace or target platform.


Reproducible: Always

Steps to Reproduce:
Setup (In an empty workspace):
1. Create a plug-in "P"
2. Create a fragment "F" that has "P" as host
3. Create a feature "E" that contains "P" but not "F"
4. Create an OSGI or Eclipse run configuration that launches the feature "E"
5. Launch and run "ss" in the console and observe that both "P" and "F" are loaded even though "F" was not included in the feature
Comment 1 Rune Glerup CLA 2011-02-24 08:01:49 EST
Created attachment 189699 [details]
Suggested patch that implements the proposed feature
Comment 2 Curtis Windatt CLA 2011-02-24 10:56:37 EST
The purpose of the feature based launched was to provide a simple way of launching a subset of features.  It is not intended to be a fully customizable launch config.  We do not plan to change this behaviour.
Comment 3 Rune Glerup CLA 2011-02-24 11:02:48 EST
(In reply to comment #2)
> The purpose of the feature based launched was to provide a simple way of
> launching a subset of features.  It is not intended to be a fully customizable
> launch config.  We do not plan to change this behaviour.

Hi Curtis

I am sorry to hear that. It would be really nice to at least have the option, because it reflects how the packaged products will run and thus enables earlier detection of dependency errors.

I have provided a patch that implements this behavior as an option in the launch configuration.

I hope you will reconsider applying this patch.
Comment 4 Jeff McAffer CLA 2011-02-24 20:15:48 EST
This is likely a dupe of bug 328515 though I did not attach a patch. ;-)  We have this unfortunate situation where several functional elements of PDE are disconnected.  You can do some things with launches but not with product and vice versa.  As a general trend it would be good to see these converge.

As it is the feature launching is attractive but does not work for the usecases that I see regularly because it is pulling in too much.  Perhaps this situation is mitigated somewhat by the product launching changes Gunnar has been proposing...
Comment 5 Rune Glerup CLA 2011-02-25 03:36:29 EST
(In reply to comment #4)
> This is likely a dupe of bug 328515 though I did not attach a patch. ;-)  We
> have this unfortunate situation where several functional elements of PDE are
> disconnected.  You can do some things with launches but not with product and
> vice versa.  As a general trend it would be good to see these converge.

I agree. This is a duplicate. I didn't search well enough before filing it.

> As it is the feature launching is attractive but does not work for the usecases
> that I see regularly because it is pulling in too much.  Perhaps this situation
> is mitigated somewhat by the product launching changes Gunnar has been
> proposing...

In our team we find the features launch incredibly useful because we are able to more effectively use a single (version-controlled) definition of which components is included in a launch.

We did need better control over which plug-ins/bundles gets deployed. And the suggested patch allows us the option to launch in a way that reflects our packaged product (without additional/optional dependencies and fragments).

It would be nice to have this or any patch that enables this behavior as at least an option to be included with PDE.
Comment 6 Jeff McAffer CLA 2011-02-25 09:54:03 EST
Does launching .product definitions work well for you?  Why not?  It seems that you are trying to get a correspondence to your shipped product so why not just launch the .product?

(Note I am not trying counter your suggested changes here.  Just looking to understand your usecase)
Comment 7 Curtis Windatt CLA 2011-02-25 10:19:57 EST
*** Bug 328515 has been marked as a duplicate of this bug. ***
Comment 8 Curtis Windatt CLA 2011-02-25 10:41:59 EST
I understand why this option would be wanted, but I also want to avoid adding any clutter to that tab.  It would be preferable if the product launch idea from bug 326059 covered your use case.
Comment 9 Rune Glerup CLA 2011-02-25 11:59:59 EST
The product launch sounds like it would cover our needs. I will give it a try.

Still, I think it that as long as there is an option to launch from features, it should be possible to get a reasonable behavior. When I launch from plug-ins/bundles I get only what I select. The same should be the case when I launch from features.

I made the fix with a checkbox to be as unintrusive as possible. If the extra checkbox makes the interface clutted, I suggest removing the checkbox. The modified behavior of not pulling bundles and fragments that are not included in the selected features could then be the default (and only) behavior.
Comment 10 Lars Vogel CLA 2019-09-24 13:59:28 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.