Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 338003 - [FieldAssist] Content Assist cue hover is cut off when it reaches the end of the screen
Summary: [FieldAssist] Content Assist cue hover is cut off when it reaches the end of ...
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6.2   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
: 305538 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-23 13:06 EST by Yujie Lin CLA
Modified: 2019-09-15 19:07 EDT (History)
9 users (show)

See Also:


Attachments
pop u perror (197.81 KB, image/jpeg)
2011-02-23 13:07 EST, Yujie Lin CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yujie Lin CLA 2011-02-23 13:06:59 EST
Build Identifier: M20100909-0800

I have a dual monitor set up.  See the attached screenshot where the pop up error message is longer than the length of the screen.  The message gets cut off.

Reproducible: Always
Comment 1 Yujie Lin CLA 2011-02-23 13:07:30 EST
Created attachment 189624 [details]
pop u perror
Comment 2 Prakash Rangaraj CLA 2011-02-24 02:19:08 EST
Forms component is owned by UA
Comment 3 Dani Megert CLA 2011-02-24 02:25:56 EST
(In reply to comment #2)
> Forms component is owned by UA
To me this looks like the cue form the combo which comes from UI. Did you verify that this is special Forms code?
Comment 4 Prakash Rangaraj CLA 2011-02-24 02:44:30 EST
(In reply to comment #3)
> (In reply to comment #2)
> > Forms component is owned by UA
> To me this looks like the cue form the combo which comes from UI. Did you
> verify that this is special Forms code?

   No, but from the screenshot, it looks like the Form's MessageManager.
Comment 5 Dani Megert CLA 2011-02-24 02:50:47 EST
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Forms component is owned by UA
> > To me this looks like the cue form the combo which comes from UI. Did you
> > verify that this is special Forms code?
> 
>    No, but from the screenshot, it looks like the Form's MessageManager.

OK, I must admit I haven't looked at that code for a long time but IIRC that class uses JFace org.eclipse.jface.fieldassist.ControlDecoration. Anyway, let's see what the Forms people say.
Comment 6 Chris Goldthorpe CLA 2011-02-24 11:00:20 EST
The control is inside a form but I don't think this is a forms bug - the form is just acting as a container and the popup is not bound by the size of the form.
Comment 7 Yujie Lin CLA 2011-02-28 15:52:06 EST
I think you guys are probably right.  I'll take another look at our code, and I suspect the bug is in our code
Comment 8 Dani Megert CLA 2011-03-01 03:47:19 EST
(In reply to comment #7)
> I think you guys are probably right.
Yes, as already indicated in comment 3 this is a bug in JFace (and not in your code).

Steps to reproduce:
1. Start a workspace.
2. Open a text file.
3. Ctrl+F.
4. Move the dialog to the right of the screen.
5. Check 'Regular expressions'.
6. Put focus into 'Find' or 'Replace with' field.
7. Hover over the light bulb.
==> The hover is cut off at the right border of the screen.
Comment 9 Prakash Rangaraj CLA 2011-03-01 04:00:50 EST
Sorry for tagging the wrong component. Correcting it
Comment 10 Remy Suen CLA 2011-08-09 08:18:08 EDT
*** Bug 305538 has been marked as a duplicate of this bug. ***
Comment 11 Helmut J. Haigermoser CLA 2011-08-09 09:28:17 EDT
WIND00290151

Ciao All :)
Can we get a statement from the JFace or Platform-UI team about this, how likely is a fix, how complicated would it be, is this an easy change we could opt to put into 3.7.1 even?
Thanks a lot! :)
Helmut
Comment 12 Remy Suen CLA 2011-08-09 13:36:43 EDT
(In reply to comment #11)
> Can we get a statement from the JFace or Platform-UI team about this, how
> likely is a fix, how complicated would it be, is this an easy change we could
> opt to put into 3.7.1 even?

Presumably we'd have to change ControlDecoration's inner Hover class's getPolygon(*) and setText(*) method so that it would return the correct location and bounds for the tooltip.

The code itself is probably not complicated but the testing might not be as straightforward (considering setups with multiple monitors and such).

Since this seems to have been broken since day one we would have to be convinced that it is worth putting into SR1 or SR2.
Comment 13 Helmut J. Haigermoser CLA 2011-08-09 13:44:05 EDT
Thanks Remy :)
(In reply to comment #12)
> The code itself is probably not complicated but the testing might not be as
> straightforward (considering setups with multiple monitors and such).
Helmut: I can help a bit by testing the fix using the issue we have found on our end

> Since this seems to have been broken since day one we would have to be
> convinced that it is worth putting into SR1 or SR2.
Helmut: I would vote for a SR? fix only if the benefit outweighs the cost, so if the risk is really small and the fix is carefree I would like to get this in, but if you guys see any risk 3.8 might be the better target..
Comment 14 Dani Megert CLA 2011-08-10 02:49:35 EDT
See also bug 352697 which indicates issues in RTL mode.
Comment 15 Helmut J. Haigermoser CLA 2011-11-14 06:43:31 EST
(In reply to comment #14)
> See also bug 352697 which indicates issues in RTL mode.

Remy,Dani,
is this bugzilla on track for a 3.8 fix?
TIA,
Ciao, hh
Comment 16 Helmut J. Haigermoser CLA 2011-11-14 06:45:20 EST
(In reply to comment #14)
> See also bug 352697 which indicates issues in RTL mode.

Remy,Dani,
is this bugzilla on track for a 3.8 fix?
TIA,
Ciao, hh
Comment 17 Dani Megert CLA 2011-11-14 10:50:13 EST
(In reply to comment #16)
> (In reply to comment #14)
> > See also bug 352697 which indicates issues in RTL mode.
> 
> Remy,Dani,
> is this bugzilla on track for a 3.8 fix?
> TIA,
> Ciao, hh

I don't think someone will work on this for 3.8. As Remy pointed out, we'd need not only shift the hover but also compute the polygon (with the arrow) in a different way and make it work for all the possible positions at which a decorator can be placed.
Comment 18 Helmut J. Haigermoser CLA 2011-11-14 10:54:59 EST
(In reply to comment #17)
> I don't think someone will work on this for 3.8. As Remy pointed out, we'd need
> not only shift the hover but also compute the polygon (with the arrow) in a
> different way and make it work for all the possible positions at which a
> decorator can be placed.

Thanks Dani! :)
How about e4, is this something that might be addressed there?
TIA,
Ciao, hh
Comment 19 Dani Megert CLA 2011-11-14 11:01:35 EST
(In reply to comment #18)
> (In reply to comment #17)
> > I don't think someone will work on this for 3.8. As Remy pointed out, we'd need
> > not only shift the hover but also compute the polygon (with the arrow) in a
> > different way and make it work for all the possible positions at which a
> > decorator can be placed.
> 
> Thanks Dani! :)
> How about e4, is this something that might be addressed there?
> TIA,
> Ciao, hh

It's not 3.x vs. 4.x. It's about finding someone who has time to work on this minor bug.
Comment 20 Helmut J. Haigermoser CLA 2011-11-14 11:02:28 EST
(In reply to comment #19)
> It's not 3.x vs. 4.x. It's about finding someone who has time to work on this
> minor bug.

Thanks Dani, I understand! :)
Helmut
Comment 21 Dani Megert CLA 2011-11-14 11:09:03 EST
(In reply to comment #20)
> (In reply to comment #19)
> > It's not 3.x vs. 4.x. It's about finding someone who has time to work on this
> > minor bug.
> 
> Thanks Dani, I understand! :)
> Helmut

Of course if someone contributes a patch we'll find time to look at it.
Comment 22 Eclipse Genie CLA 2019-09-15 19:07:58 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.