Description Axel Uhl 2011-02-23 05:36:02 EST

What should have been a side effect free getter (getLoadedPackages()) performs a side effect on the packages member variable and redundantly calls cachePackage(...). This shouldn't be the case. The following patch fixes this:

@@ -130,14 +130,14 @@ public class DefaultOppositeEndFinder
 	}
 	
 	private Set<EPackage> getLoadedPackages() {
+		Set<EPackage> result = new HashSet<EPackage>();
 		for (Object key : registry.values()) {
 			// if it's not a package descriptor indicating a not yet loaded package, add it
 			if (key instanceof EPackage) {
-				packages.add((EPackage) key);
-				cachePackage((EPackage) key);
+				result.add((EPackage) key);
 			}
 		}
-		return packages;
+		return result;
 	}
 
 	protected DefaultOppositeEndFinder(Registry registry) {