Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337947 - Write in source is very slow
Summary: Write in source is very slow
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: WTP Incubator (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Dimitar Tenev CLA
QA Contact: Dimitar Tenev CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-23 05:01 EST by Stanislav Nichev CLA
Modified: 2021-11-18 16:19 EST (History)
1 user (show)

See Also:

Attachments
fix of the performance issue (5.84 KB, patch)
2011-08-14 02:36 EDT, Stanislav Nichev CLA 		no flags Details | Diff
fix for the test (4.86 KB, patch)
2011-08-14 02:40 EDT, Stanislav Nichev CLA 		no flags Details | Diff
adding test ensuring that the UI update is run in async mode (2.62 KB, patch)
2011-08-14 02:52 EDT, Stanislav Nichev CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stanislav Nichev CLA 2011-02-23 05:01:43 EST 
Build Identifier: 

Hi Colleagues,                                                      
    If you open an big WSDL and try to write in souce page, you will
see that this is really hard because the SIE is very slow.          
                                                                    
Regards,                                                            
Tzvetan Gaydev                                                      
                                                                    
    Memo                                                            
    12.11.2010 09:57:05      Stanislav Nichev                       
Issue update: live validation is performed on each start attribute, 
start tag, start value edit, etc...                                 
                                                                    
Regards,                                                            
Stanislav                                                           


Reproducible: Always
Comment 1 Stanislav Nichev CLA 2011-08-14 01:10:39 EDT 
Hi Guys,

I've done some investigation of the issue.

It turned out that the problem is in the ValidationListener and more specifically:
resetPagesFormTitle() and updatePagesFormTitle() (ui part) methods.

I'm currently thinking of a redesign of the editor title update.

Regards,
Stanislav
Comment 2 Stanislav Nichev CLA 2011-08-14 02:36:24 EDT 
Created attachment 201471 [details]
fix of the performance issue

Hi Guys,

I've prepared a fix for the performance issue when writing in source.

The problem was in the UI update of the validation messages. 
I've put this logic inside async runnable and it did the job.

Need to attach fix for one test.

Regards,
Stanislav
Comment 3 Stanislav Nichev CLA 2011-08-14 02:40:26 EDT 
Created attachment 201472 [details]
fix for the test

Hi Guys,

I've added a "runAsyncUiUpdate" flag to the ValidationListener. If it is "true" - executes Display.asyncExec().

This flag will always be "true" for production, but it will be "false" for certain tests.
The benefits of this solution are more than the drawbacks, so I'll be happy to leave it as it is.

Regards,
Stanislav
Comment 4 Stanislav Nichev CLA 2011-08-14 02:52:46 EDT 
Created attachment 201473 [details]
adding test ensuring that the UI update is run in async mode
Comment 5 Stanislav Nichev CLA 2011-08-14 02:55:06 EDT 
Hi Guys,

I've prepared some patches for this issue.
Patches should be applied in the order they were created.

Regards,
Stanislav