Community
Participate
Working Groups
Build Identifier: This bug is intended to patch the Hermes parser with the latest code and unit-tests. Reproducible: Always
Created attachment 189567 [details] Latest code The patch contains the latest code. I also included the .classpath and .project files. Note: the projects should compile correctly now after making sure they compile against JDK 1.5. The only issue will be for the unit-tests project, I used a local library for the JUnit classes, this will need to be updated.
Pascal, Please provide a summary of the changes made in this update patch. Thanks.
The changes include: - Completion of semantic validation - Cleaner and more complete content assist - Bug fixes - More unit-tests
Created attachment 189603 [details] Updated patch, the previous didn't include the new files
Created attachment 189623 [details] TortoiseSVN integration into Windows Explorer doesn't see deleted file This new patch was created by Subclipse plug-in for Eclipse, which should contain added, modified and deleted files.
Created attachment 189626 [details] Proposed changes to manifest... Pascal, After generating the bundle with BND, using a modified standard template for eclipselink, I got a manifest with 2.3.0 as the version. I've since customized the build to allow for 1.0.0. I've also noticed you were you'd been missing exports and some minor data properties which I added. You also include imports BND doesn't. As such I've added ";resolution:=optional" to those imports as I'm not certain if they are really necessary or not. Please review and let me know if you see any issues.
(In reply to comment #6) > Created attachment 189626 [details] > Proposed changes to manifest... > > Pascal, > > After generating the bundle with BND, using a modified standard template for > eclipselink, I got a manifest with 2.3.0 as the version. > > I've since customized the build to allow for 1.0.0. I've also noticed you were > you'd been missing exports and some minor data properties which I added. You > also include imports BND doesn't. As such I've added ";resolution:=optional" to > those imports as I'm not certain if they are really necessary or not. Please > review and let me know if you see any issues. This manifest is certainly a step in the right direction. Feel free to commit this Eric.
With latest patch, code now compiles cleanly and JUnit tests are all passing. Updated code has been review for correct process and structure. Final patch has been committed to trunk.
Committed proposed manifest. Note: this is not the manifest that goes into the bundle when a build is run (unless BND is not used). I updated it for two reasons: - So that in Eclipse, PDE is closer to the actual Ant build. - To give us a starting point that is closer as I work to convert all bundle builds to be manifest first (and drop the use of BND)
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink
