Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337926 - CompletionCombo: selection events are not fired in all cases
Summary: CompletionCombo: selection events are not fired in all cases
Status: RESOLVED FIXED
Alias: None
Product: Riena
Classification: RT
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.0.0   Edit
Assignee: Elias Volanakis CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-22 20:55 EST by Elias Volanakis CLA
Modified: 2011-02-28 17:58 EST (History)
0 users

See Also:


Attachments
Snippet (4.41 KB, text/plain)
2011-02-22 21:04 EST, Elias Volanakis CLA
no flags Details
Patch v1 (3.12 KB, patch)
2011-02-22 21:04 EST, Elias Volanakis CLA
no flags Details | Diff
Updated patch (14.13 KB, patch)
2011-02-28 17:57 EST, Elias Volanakis CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Volanakis CLA 2011-02-22 20:55:46 EST
In some cases the CompletionCombo does not fire selection events -- where the original CCombo would fire them.

- text match in the text field
- text match pasted into the text field
- text match from the list

Also we should consider these cases:

- text edited in the text field, no match
- text edited in the text field, new match
- text cleared in the text field 
- text cleared via cut operation in the text field 
- text set via API (setter)
Comment 1 Elias Volanakis CLA 2011-02-22 21:04:15 EST
Created attachment 189565 [details]
Snippet
Comment 2 Elias Volanakis CLA 2011-02-22 21:04:43 EST
Created attachment 189566 [details]
Patch v1
Comment 3 Elias Volanakis CLA 2011-02-28 17:56:02 EST
Patch was doing to much. Committed different version.

Essentially: 

- user interaction triggers selection events. This means: klicking on the list, using arrows on the list or text, using mouse wheel on the list or text, typing in the text field (if a new item is selected as a result, or the selection is cleared because no match), deleting the text (=empy = no match)
- API interaction does not cause selection events. I.e. select(...), deselect(...), deselectAll(). This is consistent with what SWT does and prevents stack-overflows when listeners invoke such API.
Comment 4 Elias Volanakis CLA 2011-02-28 17:57:22 EST
Created attachment 190007 [details]
Updated patch
Comment 5 Elias Volanakis CLA 2011-02-28 17:58:24 EST
Resolved