Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337883 - Keybinding ESC key not working
Summary: Keybinding ESC key not working
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: Workbench (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.4 M6   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-22 14:07 EST by Jesus Luna Quiroga CLA
Modified: 2011-03-01 06:07 EST (History)
2 users (show)

See Also:

Attachments
Configuration (679 bytes, text/xml)
2011-02-22 14:08 EST, Jesus Luna Quiroga CLA 		no flags Details
Code (474 bytes, text/plain)
2011-02-22 14:11 EST, Jesus Luna Quiroga CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesus Luna Quiroga CLA 2011-02-22 14:07:18 EST 
Build Identifier: RAP 1.4 M5

The ESC key seems to have a problem when it is bound to an action, I attached a file with the configuration used for the keybinding in the plugin.xml and another file with the code that registers the action. 
Every other key I've tested works fine.



Reproducible: Always
Comment 1 Jesus Luna Quiroga CLA 2011-02-22 14:08:31 EST 
Created attachment 189530 [details]
Configuration
Comment 2 Jesus Luna Quiroga CLA 2011-02-22 14:11:04 EST 
Created attachment 189531 [details]
Code
Comment 3 Ivan Furnadjiev CLA 2011-03-01 04:05:08 EST 
In RCP the ESC and DEL keys are called "out-of-order" keys and they are processed in a different way in WorkbenchKeyboard#filterKeySequenceBindings. As "out-of-order" processing is not supported in RAP ( org.eclipse.swt.custom.VerifyKeyListener is missing ), now ESC and DEL key are processed in the standard way. Fixed by changing the WorkbenchKeyboard#isOutOfOrderKey() to always return false.
Comment 4 Ivan Furnadjiev CLA 2011-03-01 06:07:10 EST 
Please note that we found another issue - bug 338523, related to ESC keybinding.