Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337874 - Memory Improvement - Reduce Map creation of SDOProperty.propertyValues
Summary: Memory Improvement - Reduce Map creation of SDOProperty.propertyValues
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 334389
  Show dependency tree
 
Reported: 2011-02-22 13:21 EST by Blaise Doughan CLA
Modified: 2022-06-09 10:23 EDT (History)
0 users

See Also:


Attachments
SDO - Fix (4.27 KB, patch)
2011-02-22 13:23 EST, Blaise Doughan CLA
no flags Details | Diff
SDO - Fix (4.83 KB, patch)
2011-02-24 10:31 EST, Blaise Doughan CLA
no flags Details | Diff
SDO - Test Cases (7.38 KB, patch)
2011-02-25 12:36 EST, Blaise Doughan CLA
no flags Details | Diff
SDO - Fix (5.22 KB, patch)
2011-02-25 12:37 EST, Blaise Doughan CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Blaise Doughan CLA 2011-02-22 13:21:26 EST
Currently each instance of SDOProperty is having an instance of HashMap created for the propertyValues property.  This map should rarely need to be created.
Comment 1 Blaise Doughan CLA 2011-02-22 13:23:17 EST
Created attachment 189523 [details]
SDO - Fix
Comment 2 Blaise Doughan CLA 2011-02-24 10:31:06 EST
Created attachment 189703 [details]
SDO - Fix
Comment 3 Blaise Doughan CLA 2011-02-25 12:36:54 EST
Created attachment 189834 [details]
SDO - Test Cases
Comment 4 Blaise Doughan CLA 2011-02-25 12:37:38 EST
Created attachment 189835 [details]
SDO - Fix
Comment 5 Blaise Doughan CLA 2011-02-25 13:42:07 EST
Fix checked into trunk at rev:  9036
Fix checked into 2.2.1 at rev:  9037
Fix checked into 2.1.3 at rev:  9038

ode reviewed by:  David McCann

The most common open content property for Property is "xmlElement".  This was causing an entire map to be created just for this one value.  As an optimization this value has been pulled into its own instance variable.  The creation of the Map is delayed until another open content property is added.
Comment 6 Eclipse Webmaster CLA 2022-06-09 10:23:32 EDT
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink