Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337830 - Java Metamodel : org.eclipse.gmt.modisco.java should use MinimalEObjectImpl
Summary: Java Metamodel : org.eclipse.gmt.modisco.java should use MinimalEObjectImpl
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Technologies (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 0.9.0 M7   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-22 09:08 EST by Fabien Giquel CLA
Modified: 2011-08-18 07:52 EDT (History)
3 users (show)

See Also:
nicolas.bros: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabien Giquel CLA 2011-02-22 09:08:40 EST 
org.eclipse.gmt.modisco.java.classicEObject is dedicated to one standard EMF implementation (EObjectImpl root class).
org.eclipse.gmt.modisco.java should rely on MinimalEObjectImpl since benchmarks show its interest as a default implementation. Some past wrong move/refactoring have been done between SVN repositories and MinimalEObjectImpl inheritance has been lost.
Comment 1 Nicolas Bros CLA 2011-04-04 10:53:43 EDT 
Fixed in revision 4233.
Comment 2 Fabien Giquel CLA 2011-04-05 03:42:16 EDT 
It is important to notice that modifying the inheritance does not violate API freeze by M6 :

- both MinimaEObjectImpl & EObjectImpl implement EObject interface
- EObjectImpl did not provide additional public/protected method compared to MinimaEObjectImpl.
Comment 3 Hugo Bruneliere CLA 2011-08-18 07:52:37 EDT 
Upgrade done.