Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337810 - [Tooling] Add target platform validation to the RAP templates wizard
Summary: [Tooling] Add target platform validation to the RAP templates wizard
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: Tools (show other bugs)
Version: 1.4   Edit
Hardware: Macintosh All
: P3 enhancement (vote)
Target Milestone: 1.4 M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-22 05:58 EST by Holger Staudacher CLA
Modified: 2011-04-20 08:56 EDT (History)
2 users (show)

See Also:

Attachments
Version 1 (22.55 KB, patch)
2011-03-05 05:39 EST, Beyhan Veliev CLA 		holger.staudacher: iplog+
Details | Diff
Question dialog instead check box (13.28 KB, patch)
2011-04-20 06:43 EDT, Beyhan Veliev CLA 		holger.staudacher: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Staudacher CLA 2011-02-22 05:58:45 EST 
During the discussion on bug 223929 Beyhan came up with the idea to add a target platform validation for our RAP templates. I like this idea very much. I think this should happen when you have selected a RAP template and click finish. A dialog should come up that says that the current target platform will not work for this template if the platform does not contain org.eclipse.rap.ui. An option should be added to install the target within this dialog. 

 I'm not sure but maybe we can avoid a dialog and add this check to the existing wizard?
Comment 1 Rüdiger Herrmann CLA 2011-02-24 11:57:45 EST 
(In reply to comment #0)
> [ ... ]
>  I'm not sure but maybe we can avoid a dialog and add this check to the
> existing wizard?
I would try hard to avoid the dialog. Under certain circumstances, there is already a dialog that asks the user whether the PDE perspective should be shown.
Comment 2 Beyhan Veliev CLA 2011-02-25 03:19:11 EST 
>I'm not sure but maybe we can avoid a dialog and add this check to the
>existing wizard?
+1
Comment 3 Beyhan Veliev CLA 2011-03-05 05:39:55 EST 
Created attachment 190466 [details]
Version 1

Provided patch adds a check box ('Check RAP target installed') to the existing RAP template wizard. Default value is 'true'. RAP target platform installation dialog shows up after template wizard is closed if 'org.eclipse.rap.ui' isn't found under the active models and check box is selected.
Comment 4 Holger Staudacher CLA 2011-04-14 05:37:23 EDT 
I reviewed the patch together with Beyhan. We did some little refactorings and I committed the changes to CVS HEAD.
Comment 5 Beyhan Veliev CLA 2011-04-20 06:43:21 EDT 
Created attachment 193680 [details]
Question dialog instead check box

After some discussions with Ralf we decided to remove the check box on the template wizard and open an question dialog if RAP target is not installed.
Comment 6 Beyhan Veliev CLA 2011-04-20 06:43:46 EDT 
After some discussions with Ralf we decided to remove the check box on the template wizard and open an question dialog if RAP target is not installed.
Comment 7 Holger Staudacher CLA 2011-04-20 08:56:35 EDT 
Thanks for the patch. i reviewed the changes and did a little refactoring. The changes are now in CVS HEAD.