Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337744 - Cherry-pick in menu would be better as Cherry Pick
Summary: Cherry-pick in menu would be better as Cherry Pick
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 trivial (vote)
Target Milestone: ---   Edit
Assignee: Stefan Lay CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-21 12:56 EST by Alex Blewitt CLA
Modified: 2011-10-31 10:41 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2011-02-21 12:56:55 EST
In the history view, right-clicking gives a menu with a list of options. One of these is 'Cherry-pick'. This seems to be inconsistent as almost all other menu items have spaces instead of hyphens in them.

It would be better if this was 'Cherry Pick' instead of 'Cherry-pick'.

minidiff (tm):

org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties
- GitHistoryPage_cherryPickMenuItem=C&herry-pick	
+ GitHistoryPage_cherryPickMenuItem=C&herry Pick
Comment 1 Stefan Lay CLA 2011-03-02 08:15:51 EST
Code Review at http://egit.eclipse.org/r/#change,2623
Comment 2 Stefan Lay CLA 2011-03-07 09:24:20 EST
Fixed with 40da4ea32977a4d4577dfe1099dd6b783aac5f67
Comment 3 Dani Megert CLA 2011-09-29 03:11:08 EDT
I would actually disagree since the correct spelling (see e.g. http://www.merriam-webster.com/) and also how it's used in the Git doc is "cherry-pick". ==> "Cherry-Pick"
Comment 4 Dani Megert CLA 2011-10-31 10:41:05 EDT
Ping!