Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337735 - Remove workarounds for Ant builder bug in Jar in Jar Loader
Summary: Remove workarounds for Ant builder bug in Jar in Jar Loader
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 trivial (vote)
Target Milestone: 3.7 M6   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-21 11:12 EST by Markus Keller CLA
Modified: 2012-01-27 14:37 EST (History)
4 users (show)

See Also:

Attachments
Fix (3.49 KB, patch)
2011-02-21 11:12 EST, Markus Keller CLA 		no flags Details | Diff
Fix 2 (3.44 KB, patch)
2011-02-21 14:15 EST, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-02-21 11:12:24 EST 
Created attachment 189420 [details]
Fix

Remove workarounds for Ant builder bug in Jar in Jar Loader
Comment 1 Markus Keller CLA 2011-02-21 14:15:29 EST 
Created attachment 189436 [details]
Fix 2

I've released the first patch, but then I saw that this causes the Jar to be rebuilt after clean. That's not what we want. We need to keep the empty "After a Clean" task. I've updated the comment in build_jar-in-jar-loader.xml.
Comment 2 Markus Keller CLA 2011-02-21 14:20:32 EST 
Fixed in HEAD.

JDT/UI Team: Please ignore any outgoing changes in
    /org.eclipse.jdt.ui/jar-in-jar-loader.zip
that could show up in your workspace if you updated to the first fix.
Comment 3 Markus Keller CLA 2012-01-25 13:37:38 EST 
The workarounds were for bug 114563.
Comment 4 Dani Megert CLA 2012-01-25 15:43:08 EST 
(In reply to comment #3)
> The workarounds were for bug 114563.

So, they can be removed now?
Comment 5 Markus Keller CLA 2012-01-27 14:37:20 EST 
(In reply to comment #4)
> (In reply to comment #3)
> > The workarounds were for bug 114563.
> 
> So, they can be removed now?

No. The workarounds were initially to avoid bug 114563, but when I wanted to remove them, I found that the dummy clean target is still necessary, see comment 2. The workaround has morphed into the proper fix, and I've documented that in build_jar-in-jar-loader.xml.

Bug 335999 updated the doc to explain the 4 build targets.