Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337729 - Undo of change def tns breaks bindings
Summary: Undo of change def tns breaks bindings
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: WTP Incubator (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Dimitar Tenev CLA
QA Contact: Dimitar Tenev CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-21 10:03 EST by Stanislav Nichev CLA
Modified: 2021-11-18 16:19 EST (History)
2 users (show)

See Also:

Attachments
updating ModelReconciler to fix the bindings :) (10.84 KB, patch)
2011-03-16 03:48 EDT, Stanislav Nichev CLA 		no flags Details | Diff
Patch updating the WSDL model reconciler + test (69.24 KB, patch)
2011-07-28 15:00 EDT, Stanislav Nichev CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stanislav Nichev CLA 2011-02-21 10:03:51 EST 
Build Identifier: 

Hi Colleagues,
                                                                                
In SIE 731 the following scenario fails:                                         
1) Create new WSDL with bindings 
2) Open it in the SIE 
3) Change the definition tns
4) Ctrl+Z
 
A warning message is shown in the title.
       
Cause: During the undo of the operation, the binding port type needs to be updated. However - in the eBinding instance, the ePortType is null.           
It needs to be reconciled - eBinding.setEPortType(ePortType) method 
must be called.                                              
BUT: This method call updates the DOM, thus breaking any subsequent undo/redo operations. Another solution of the problem needs to be found.         

Regards,                                                                        Stanislav                                                                      

Reproducible: Always
Comment 1 Stanislav Nichev CLA 2011-03-16 03:48:48 EDT 
Created attachment 191281 [details]
updating ModelReconciler to fix the bindings :)

Hi Colleagues,

Attaching fix. Unit tests still needs to be developed or existing one should be updated.

Regards,
Stanislav
Comment 2 Stanislav Nichev CLA 2011-07-28 15:00:30 EDT 
Created attachment 200550 [details]
Patch updating the WSDL model reconciler + test

Hi Guys,

I've prepared a new patch, including a test. The test should make sure no regressions are introduced.

Regards,
Stanislav
Comment 3 Stanislav Nichev CLA 2011-08-13 13:29:22 EDT 
Hi Guys,

I'm setting priority to major, since the issue is with high visibility and is reproducible every time when there are bindings in the WSDL document.

Regards,
Stanislav
Comment 4 Dimitar Tenev CLA 2011-08-26 08:26:20 EDT 
Thanks Stani,

I have retested, and applied the fix.

Best regards,
Dimitar