337714 – streamline ChangeGenerator

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337714 - streamline ChangeGenerator

Summary: streamline ChangeGenerator

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-refactoring (show other bugs)
Version:	8.0
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	8.0
Assignee:	Emanuel Graf
QA Contact:	Emanuel Graf

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-02-21 07:36 EST by Emanuel Graf
Modified:	2011-02-21 09:23 EST (History)
CC List:	1 user (show)

See Also:

Attachments
Patch (48.57 KB, patch) 2011-02-21 08:24 EST, Emanuel Graf	emanuel: iplog-	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Emanuel Graf

2011-02-21 07:36:25 EST

The class ChangeGenerator contains superfluous code and uses the deprecated CPPASTVisitor.

Comment 1 Emanuel Graf

2011-02-21 08:24:52 EST

Created attachment 189408 [details]
Patch

Comment 2 Emanuel Graf

2011-02-21 08:45:54 EST

Fixed in HEAD > 20110221

Comment 3 CDT Genie

2011-02-21 09:23:12 EST

*** cdt cvs genie on behalf of egraf ***
Bug 337714: Fixed streamline ChangeGenerator
<a  href=https://bugs.eclipse.org/bugs/show_bug.cgi?id=337714>https://bugs.eclipse.org/bugs/show_bug.cgi?id=337714</a>

[+] SelfInsertionTest.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/changegenerator/insertbefore/SelfInsertionTest.java?root=Tools_Project&revision=1.1&view=markup
[+] MultilineWhitespaceHandlingTest.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/changegenerator/insertbefore/MultilineWhitespaceHandlingTest.java?root=Tools_Project&revision=1.1&view=markup
[*] InsertBeforeTestSuite.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/changegenerator/insertbefore/InsertBeforeTestSuite.java?root=Tools_Project&r1=1.3&r2=1.4
[*] AddDeclarationBug.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/changegenerator/insertbefore/AddDeclarationBug.java?root=Tools_Project&r1=1.1&r2=1.2

[+] ReplaceForLoopBodyTest.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/changegenerator/replace/ReplaceForLoopBodyTest.java?root=Tools_Project&revision=1.1&view=markup
[+] WhitespaceHandlingTest.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/changegenerator/replace/WhitespaceHandlingTest.java?root=Tools_Project&revision=1.1&view=markup
[+] MultilineWhitespaceHandlingTest.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/changegenerator/replace/MultilineWhitespaceHandlingTest.java?root=Tools_Project&revision=1.1&view=markup

[*] ChangeGeneratorTest.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/changegenerator/ChangeGeneratorTest.java?root=Tools_Project&r1=1.2&r2=1.3
[*] ChangeGeneratorTestSuite.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/changegenerator/ChangeGeneratorTestSuite.java?root=Tools_Project&r1=1.2&r2=1.3

[*] ChangeGenerator.java 1.19 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/changegenerator/ChangeGenerator.java?root=Tools_Project&r1=1.18&r2=1.19
[*] ChangeGeneratorWriterVisitor.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/changegenerator/ChangeGeneratorWriterVisitor.java?root=Tools_Project&r1=1.8&r2=1.9

[*] ImplementMethod.rts 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui.tests/resources/refactoring/ImplementMethod.rts?root=Tools_Project&r1=1.11&r2=1.12
[*] GenerateGettersAndSetters.rts 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui.tests/resources/refactoring/GenerateGettersAndSetters.rts?root=Tools_Project&r1=1.11&r2=1.12
[*] ExtractMethod.rts 1.17 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui.tests/resources/refactoring/ExtractMethod.rts?root=Tools_Project&r1=1.16&r2=1.17
[*] ExtractMethodHistory.rts 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui.tests/resources/refactoring/ExtractMethodHistory.rts?root=Tools_Project&r1=1.2&r2=1.3
[*] HideMethod.rts 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui.tests/resources/refactoring/HideMethod.rts?root=Tools_Project&r1=1.3&r2=1.4