Community
Participate
Working Groups
DSF-GDB is missing support for a MI command which was supported in CDI: -exec-arguments The corresponding CDI class was org.eclipse.cdt.debug.mi.core.command.MIExecArguments, and we need a similar class in DSF. The accompanying patch contains a class org.eclipse.cdt.dsf.mi.service.command.commands.MIExecArguments and a corresponding method createMIExecArguments() in CommandFactory. Could not figure out what should be the value of the @since tag, some help would be very appreciated. This bug can also be classified under the CDI - DSF feature parity effort.
Created attachment 189395 [details] Initial patch
I have nothing against this, but I'm just curious to know if there is a reason you don't want to use MIGDBSetArgs. That is what we use in DSF-GDB and looking at the GDB source code, it is identical to -exec-arguments. To be honest, I don't why DSF-GDB uses -gdb-set args instead of -exec-arguments. For the patch, -exec-arguments should be made process-specific (using a IMIContainerDMContext instead of IControlDMC). This is a very recent change I have made to MIGDBSetArgs
(In reply to comment #2) > For the patch, -exec-arguments should be made process-specific (using a > IMIContainerDMContext instead of IControlDMC). This is a very recent change I > have made to MIGDBSetArgs See Bug 337602 about this.
Actually, I noticed MIGDBSetArgs exactly after filing this bug. Wanted to have MIExecArguments because we are porting our old launches based on CDI to DSF, and the old launches use MIExecArguments (the CDI one). If both these commands are identical, guess it would be perfectly fine to use MIGDBSetArgs instead. Lack of MIExecArguments will only be noticed by people trying to port their launch from CDI to DSF, since MIGDBSetArgs is not available in CDI. Maybe there can be some documentation by which we can come to know that MIGDBSetArgs can be used in place of MIExecArguments. If you are ok with having MIExecArguments also, I will update the patch to use IMIContainerDMContext.
(In reply to comment #4) > If you are ok with having MIExecArguments also, I will update the patch to use > IMIContainerDMContext. What I like about -gdb-set args is that there is a corresponding -gdb-show args, which is useful when debugging. Although -gdb-show args can be used with -exec-arguments, I just felt that it made more sense to use -gdb-set args. That being said, I think it is fine to add the class MIExecArguments, and put a comment in the javadoc to say MIGDBSetArgs does the same thing. That will give users the choice. If you can update the patch, I will commit it. Please put your copyright name and bug number at the top of each file. Thanks
Created attachment 189573 [details] Patch with @since 4.0 tags
Have updated the patch with @since 4.0 tags, copyright name and bug number.
(In reply to comment #7) > Have updated the patch with @since 4.0 tags, copyright name and bug number. You didn't want to change the patch to use IMIContainerDMContext?
Created attachment 189781 [details] Patch using IMIContainerDMContext Sorry for the oversight. Updated the patch to use IMIContainerDMContext instead of ICommandControlDMContext.
Committed to HEAD. Thanks Abeer.
*** cdt cvs genie on behalf of mkhouzam *** Bug 337687: Support for MI command -exec-arguments [+] MIExecArguments.java http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIExecArguments.java?root=Tools_Project&revision=1.1&view=markup [*] CommandFactory.java 1.21 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/CommandFactory.java?root=Tools_Project&r1=1.20&r2=1.21
