Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337608 - Extended bounds of BorderedNodeFigure not always refreshed when needed
Summary: Extended bounds of BorderedNodeFigure not always refreshed when needed
Status: ASSIGNED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: ---   Edit
Assignee: Lidija Grahek CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-18 15:25 EST by Lidija Grahek CLA
Modified: 2011-07-25 03:40 EDT (History)
2 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2011-02-18 15:27 EST, Lidija Grahek CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lidija Grahek CLA 2011-02-18 15:25:36 EST 
getExtendedBounds() in BorderedNodeFigure will recalculate extendedBounds only if it is null, and it is being set to null by invalidate(), validate() and fireFigureMoved(), which seems right. The only problem is that in fireFigureMoved() extendedBounds is being set to nul after calling super.fireFigureMove(), so all container size calculations are going to use the old extended bounds of this figure, which is wrong. extendedBounds needs to be re-set before calling super.fireFigureMoved().
Comment 1 Lidija Grahek CLA 2011-02-18 15:27:04 EST 
Created attachment 189317 [details]
Patch

The patch is attached. Alex, could you take a look? Thanks.