Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337519 - Filter column doesn't work on Linux
Summary: Filter column doesn't work on Linux
Status: RESOLVED FIXED
Alias: None
Product: MAT
Classification: Tools
Component: GUI (show other bugs)
Version: 1.1   Edit
Hardware: All Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Andrew Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-18 02:08 EST by Andrew Johnson CLA
Modified: 2011-07-29 09:45 EDT (History)
1 user (show)

See Also:

Attachments
Patch for UI filter textfield for Linux (671 bytes, patch)
2011-05-24 05:20 EDT, Brian Peacock CLA 		krum.tsvetkov: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Johnson CLA 2011-02-18 02:08:44 EST 
The filter column doesn't work in Linux. Double click or pressing enter doesn't open the text box at the top of the column in the histogram or tree view.

This works on Windows.

Try looking at RefinedResultViewer.addDoubleClickListener()
Comment 1 Andrew Johnson CLA 2011-02-18 02:29:21 EST 
Does context menu->Columns->Edit value work?

I don't have a Linux system to test.
Comment 2 Brian Peacock CLA 2011-05-24 04:19:06 EDT 
The code does in fact work, it's just the way it is displayed is somewhat misleading on Linux.
The field is in fact a textfield but it doesn't look like one. If the field is clicked, you can start typing characters and as soon as the first one appears the field turns into a textfield.

To make it appear (and behave) as expected, I set the Text to be a space and then the textfield is displayed:

RefinedResultViewer.activateEditor()

        final Text text = new Text(composite, SWT.NONE);
        text.setText(" ");
Comment 3 Brian Peacock CLA 2011-05-24 04:25:25 EDT 
With this change the textfield appears as expected and can be typed into as normal. The space automatically gets removed so the textfield behaves as expected.

This has been tested on Windows and doesn't cause any problems there.
Comment 4 Brian Peacock CLA 2011-05-24 05:20:03 EDT 
Created attachment 196411 [details]
Patch for UI filter textfield for Linux
Comment 5 Andrew Johnson CLA 2011-06-27 04:45:20 EDT 
Fix applied as described