Comment 1 Nicolas Guyomar 2011-03-09 05:19:50 EST

Created attachment 190745 [details]
Patch for Bug 337454

Hi,

Indeed it was a missing functionality.
Please find attached a patch which modify the org.eclipse.emf.facet.widgets.nattable plug-in so that it is possible to delete a query column : 
- right click on the query column header
- select the usual "delete" action from the pop-up menu

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar

Comment 2 Gregoire Dupe 2011-03-09 08:21:54 EST

Comment on attachment 190745 [details]
Patch for Bug 337454

Hi,

Here are a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution. Committed revision 349. 

This solves the problem in the editor but not in the view.

Regards,
Gregoire

Comment 3 Nicolas Guyomar 2011-03-09 08:44:52 EST

Created attachment 190752 [details]
Bug 337454 - Fix for the View

Hi,

Indeed the view suffered from an handler problem, I fixed it in the attached patch

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar

Comment 4 Gregoire Dupe 2011-03-09 09:46:48 EST

Comment on attachment 190752 [details]
Bug 337454 - Fix for the View

Here are a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution. (Without the modifications in NatTableWidget because those modifications fix the bug 337395)

Committed revision 350.

Comment 5 Gregoire Dupe 2011-03-09 09:47:31 EST

This bug can be marked has fixed.

Comment 6 Vincent Lorenzo 2011-03-11 07:19:07 EST

I can't close this bug, because there is refresh problem with the Delete action in the Menu Edit.
When you select a query column to delete it, the action in the popup menu is enabled (that's OK), but in the Menu Edit, it is disabled.

I find the same problem, when I want delete an element from the model.

Comment 7 Nicolas Guyomar 2011-03-17 05:35:33 EDT

Created attachment 191388 [details]
Bug 337454 - Fix for the refresh

(In reply to comment #6)
Hi,

The Edit>Delete state has been fixed, as well as the fact that it was only possible to delete one QueryColumn at the time.

I have provided the table with a more convenient way to deal with column selection in NatTableWidget class

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar

Comment 8 Gregoire Dupe 2011-03-17 09:23:10 EDT

Comment on attachment 191388 [details]
Bug 337454 - Fix for the refresh


Here are a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 428.

Comment 9 Gregoire Dupe 2011-03-17 09:24:12 EDT

This bug can be marked as resolved.

Comment 10 Vincent Lorenzo 2011-03-25 05:23:09 EDT

This bug can be marked as closed.