Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337405 - XslfoDocumentBuilder assumes that image width is specified in pixels
Summary: XslfoDocumentBuilder assumes that image width is specified in pixels
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.4.0   Edit
Assignee: Torkild Resheim CLA
QA Contact: David Green CLA
URL:
Whiteboard:
Keywords: contributed
Depends on: 338891
Blocks:
  Show dependency tree
 
Reported: 2011-02-17 05:16 EST by Torkild Resheim CLA
Modified: 2011-03-04 02:10 EST (History)
0 users

See Also:

Attachments
Patch to handle image width in both pixels and percent (3.51 KB, patch)
2011-02-17 07:12 EST, Torkild Resheim CLA 		greensopinion: iplog+
Details | Diff
mylyn/context/zip (1.16 KB, application/octet-stream)
2011-02-17 07:12 EST, Torkild Resheim CLA 		no flags Details
mylyn/context/zip (41.33 KB, application/octet-stream)
2011-03-03 00:57 EST, David Green CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Torkild Resheim CLA 2011-02-17 05:16:33 EST 
The WikiText markup parser support image sizes being in pixels and in percent. The XslfoDocumentBuilder assumes that the image width is in pixels and does not support that the size may be specified in percent. Note that the HtmlDocumentBuilder does support both formats. In other words when generating HTML a image size of 50% will show up as normal. But when generating XSL:FO the size will be 50pixels.
Comment 1 Torkild Resheim CLA 2011-02-17 07:12:23 EST 
Created attachment 189168 [details]
Patch to handle image width in both pixels and percent
Comment 2 Torkild Resheim CLA 2011-02-17 07:12:25 EST 
Created attachment 189169 [details]
mylyn/context/zip
Comment 3 David Green CLA 2011-03-03 00:57:25 EST 
Thanks, patch applied with minor changes.  I wrote  a JUnit test @org.eclipse.mylyn.wikitext.core.parser.XslfoDocumentBuilderTest@, feel free to expand on tests with future patches.
Comment 4 David Green CLA 2011-03-03 00:57:28 EST 
Created attachment 190236 [details]
mylyn/context/zip
Comment 5 Steffen Pingel CLA 2011-03-03 01:38:33 EST 
David, please note that we are past the contribution deadline for 1.4 (3.5). Shouldn't be a problem since we are still iterating over the IP log but please be aware that we can't accept any further contributions for this release cycle: http://dev.eclipse.org/mhonarc/lists/mylyn-dev/msg01202.html .
Comment 6 David Green CLA 2011-03-03 01:50:40 EST 
Thanks for pointing that out Steffen.  If it's a problem I'll update the target milestone and we can build WikiText for 3.5 off a branch.