Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337404 - [cds] Rework of the SolrRepository concept and impl
Summary: [cds] Rework of the SolrRepository concept and impl
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: gyrex (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mike Tschierschke CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-17 04:55 EST by Mike Tschierschke CLA
Modified: 2018-03-19 11:59 EDT (History)
2 users (show)

See Also:


Attachments
removed solr multiple collections capability (97.52 KB, patch)
2011-02-24 02:05 EST, Mike Tschierschke CLA
no flags Details | Diff
simplified IDocumentManager (137.40 KB, patch)
2011-02-25 09:51 EST, Mike Tschierschke CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Tschierschke CLA 2011-02-17 04:55:15 EST
At the moment each Gyrex application, that uses solr indices, has max one solr repository in each runtime context. Different indices are modeled as different collections in each repository.

This concept is obsolete. Each solr repository should represent one index. This relation must not be one-to-one. Different repos may connect to the same index.
Comment 1 Gunnar Wagenknecht CLA 2011-02-19 04:06:19 EST
As discussed, we should rework the concept and remove collections all together. They aren't bad per definition but they add a layer of complexity that we don't want to introduce at this stage.

Mike, you also need to refactor the Solr based CDS managers to allow extensibility by others. Once you have a patch ready feel free to attach for API discussion.
Comment 2 Mike Tschierschke CLA 2011-02-24 02:05:11 EST
Created attachment 189672 [details]
removed solr multiple collections capability

Finished the rework on solr repositories by removing the capability to manage multiple document collections. Now, each solr repository is a wrapper for exactly one collection.
Also removed pre-definded repository content types for document and facet repos.

Gunnar, please review my changes.
Comment 3 Mike Tschierschke CLA 2011-02-25 09:51:47 EST
Created attachment 189807 [details]
simplified IDocumentManager

As discussed, I simplified the IDocumentManager concept by removing the interfaces IDocumentCollection, ISolrDocumentCollection and ISolrQueryExecutor. Each method is now integrated in the IDocumentManager and impl
Comment 4 Gunnar Wagenknecht CLA 2011-02-26 11:19:13 EST
Patch committed. Thanks Mike!