Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337363 - Many "NLS unused message" messages are logged into the .log file
Summary: Many "NLS unused message" messages are logged into the .log file
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.4   Edit
Assignee: Michael Rennie CLA
QA Contact: Michael Rennie CLA
URL:
Whiteboard:
Keywords:
: 338378 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-16 16:24 EST by Kit Lo CLA
Modified: 2011-06-27 17:26 EDT (History)
3 users (show)

See Also:

Attachments
.log file (8.69 KB, text/plain)
2011-02-16 16:24 EST, Kit Lo CLA 		no flags Details
fix (15.28 KB, patch)
2011-02-28 12:49 EST, Michael Rennie CLA 		no flags Details | Diff
fix for 3.2.4 (6.39 KB, patch)
2011-02-28 13:04 EST, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kit Lo CLA 2011-02-16 16:24:57 EST 
Created attachment 189130 [details]
.log file

Build: wtp-M-3.2.3-20110211193042.zip

After adding the "Editing and validating XML files" example project to the workspace, many "NLS unused message" messages are logged into the .log file EVERY TIME we launch Eclipse. This will fill up the .log file quickly.

The messages are not related to the NL packs. They mean there is a string in the properties file but there is no corresponding key in the messages Java file. This suggests a mismatch between the Java file where the keys are defined and the property file.
Comment 1 Michael Rennie CLA 2011-02-17 12:34:39 EST 
Using the code from the 3.2.2 and 3.2.3 branches I cannot reproduce these log entries - all entries match up in the messages.properties and Messages.java.

I will grab the build mentioned and check it.
Comment 2 Nitin Dahyabhai CLA 2011-02-28 09:46:34 EST 
*** Bug 338378 has been marked as a duplicate of this bug. ***
Comment 3 Michael Rennie CLA 2011-02-28 12:49:40 EST 
Created attachment 189974 [details]
fix

Ran the tooling to find broken NLS messages, the patch contains the removals of the unused messages.
Comment 4 Michael Rennie CLA 2011-02-28 13:04:02 EST 
Created attachment 189976 [details]
fix for 3.2.4

This is the patch for the 3.2.x branch. When I compared the changes to the missing NLS messages in the attached log I found many of the entries to be false-positives.

for example:

1. !ENTRY org.eclipse.osgi 2 1 2011-02-16 16:12:37.432
!MESSAGE NLS unused message: the_argument_0_is_not_valid in: org.eclipse.wst.jsdt.debug.internal.ui.messages

that message is being used int JavaScriptConnectTab

2. !ENTRY org.eclipse.osgi 2 1 2011-02-16 16:12:37.354
!MESSAGE NLS unused message: add_script_load_bp in: org.eclipse.wst.jsdt.debug.internal.ui.messages

that message is being used in AddScriptLoadBrekapointAction

3. !ENTRY org.eclipse.osgi 2 1 2011-02-16 16:12:37.370
!MESSAGE NLS unused message: bp_hit_count in: org.eclipse.wst.jsdt.debug.internal.ui.messages

that message is used in JavaScriptModelPresentation

there are many more of them, and I do not know why they are being reported as not being used.
Comment 5 Michael Rennie CLA 2011-02-28 13:14:47 EST 
I applied the first patch to HEAD.
Comment 6 Michael Rennie CLA 2011-03-23 15:55:17 EDT 
applied the patch to 3.2.4 as well