Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337359 - More Confirmation dialogs needed on some git actions
Summary: More Confirmation dialogs needed on some git actions
Status: RESOLVED WORKSFORME
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.12   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-16 15:55 EST by CLA
Modified: 2019-12-11 09:06 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description CLA 2011-02-16 15:55:41 EST 
I accidentally selected "Cherry-pick" from the menu. The change was made, there was no "Are you sure?" message. Please could we have more confirmation dialogs on actions "Cherry-pick", "Revert Commit", "Merge" and anything else that makes a sudden change?
Comment 1 Stefan Lay CLA 2011-02-21 09:18:05 EST 
The actions you mentioned don't damage any data. All of them can be reverted with a reset.

If you have done an action by mistake and have moved your HEAD, you can lookup its former position using git reflog on the command line.
Comment 2 CLA 2011-02-21 10:39:27 EST 
(In reply to comment #1)
> The actions you mentioned don't damage any data. All of them can be reverted
> with a reset.
> 
> If you have done an action by mistake and have moved your HEAD, you can lookup
> its former position using git reflog on the command line.

Sure, that's possible. But really, an action such as this should have a confirmation dialog to show the user what they will be doing.
Comment 3 Craig CLA 2012-04-10 02:59:03 EDT 
IMO: Commands like pull and "Disconnect" should also have confirmation dialogs.
What about a preference setting? It can be disabled by default.
Comment 4 Johan Compagner CLA 2019-12-11 08:34:32 EST 
i would say this bug can be closed, because having confirmation dialogs for everything is very annoying, only if you make a mistake that is not reversible that should be given an dialog like that.
Comment 5 Matthias Sohn CLA 2019-12-11 09:06:29 EST 
yep, I think we have enough confirmation dialogs, most of them can be turned off in preferences