Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337319 - PERF: valueFromPKList should bulk read related entities
Summary: PERF: valueFromPKList should bulk read related entities
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 335448 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-16 10:04 EST by Gordon Yorke CLA
Modified: 2022-06-09 10:28 EDT (History)
1 user (show)

See Also:

Attachments
Proposed Patch (55.94 KB, patch)
2011-02-16 10:37 EST, Gordon Yorke CLA 		no flags Details | Diff
Final Patch (65.15 KB, patch)
2011-02-17 15:08 EST, Gordon Yorke CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gordon Yorke CLA 2011-02-16 10:04:26 EST 
valueFromPKList is used when loading Entities by PK for a relationship.  Currently this code issues a ReadObject query for each PK value and this is terribly inefficient.  The code should be changed to bulk load from the cache and then bulk load from the database using IN.
Comment 1 Gordon Yorke CLA 2011-02-16 10:37:54 EST 
Created attachment 189106 [details]
Proposed Patch

This patch add bulk load from cache functionality and bulk load from database for valueFromPKList.
Comment 2 Gordon Yorke CLA 2011-02-17 15:08:13 EST 
Created attachment 189222 [details]
Final Patch

Small change to support ordering of the getAll values.
Comment 3 Gordon Yorke CLA 2011-02-17 15:37:11 EST 
Checked In
Reviewed by James Sutherland
Comment 4 Gordon Yorke CLA 2011-04-13 15:02:33 EDT 
*** Bug 335448 has been marked as a duplicate of this bug. ***
Comment 5 Eclipse Webmaster CLA 2022-06-09 10:28:21 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink