Community
Participate
Working Groups
this is a prerequisite for issue 335407 in order to be able to have a hyperlink and jump to file location where the given marker error originates, we need some details included in the marker. At the very least we need the originating model's coordinates/path.
Done for: ActionMessageProblemInfo MissingConfiguratorProblemInfo MissingLifecycleExtensionPoint MissingLifecyclePackaging NotCoveredMojoExecution http://git.eclipse.org/c/m2e/m2e-core.git/commit/?id=29e2fc24b109e0531f9bdddf6f53a5a78d29f24d https://github.com/sonatype/m2e-core-tests/commit/497997613c13b170a394289fdfc134c16eda58f1
Fixed the problems introduced by the previous commit and added location info to a few more markers: http://git.eclipse.org/c/m2e/m2e-core.git/commit/?id=d89a8c63aa2f569dfd1c2f649447ed31ffed44fa https://github.com/sonatype/m2e-core-tests/commit/169fc7883aaded321ebd3163ed9ee321ca227463
it appears you have decided to rewrite the the way markers are located in the current file as part of this issue. Unfortunately it's not entirely correct. Let me give you a UI specification: 1. if placed on an xml element with text eg. <artifactId>id</artifactId> then the entire element is to be marked. 2. if placed on xml element with child elements eg. <plugin></plugin>, then only the start tag shall be marker (thus <plugin>) 3. the marker shall always be placed on the most detailed placement. Eg. if the error deals with a plugin goal within an execution, then the goal's xml element shall be marked. 4. if the marker deals with more complex entity (eg. execution or plugin) then the plugin's identifier is to be marker (thus <artifactId> in case of plugin) 5. if the correct element cannot be located because it's entirely or partly defined in one of the parents, then the best match shall be found in the current file. let me give you an example. let's have a marker for missing mapping for enforcer's validate goal. a. if goal itself if not found, and the plugin itself is defined in the current file, then it's <artifactId> is to be marked. b. if the plugin is not even defined in the current file, then <plugins> element is to be used. c. if the <plugins> element is not found, then <build> element is to be used. d. if build is not found, the <project> is to be used.
The new marker locations make more sense *to me*. Which probably doesn't mean much, as I'm not a UI developer. :) I can't really say I agree or disagree with your comments. I believe any discussion about marker location(s) should be put in the context of a specific marker/problem. Mainly because each problem can be caused by different parts of pom files and the marker location should ultimately help the user solve (or understand) that specific problem.
Added source id to SourceLocation
http://git.eclipse.org/c/m2e/m2e-core.git/commit/?id=a6b6ea7bf2b707688b2449c8cbe45b750f3e7b72 we now have a hyperlink (in xml editor on ctrl-click or on hover, hover also applicable in form's header popup) the only outstanding issue is the naming of the hyperlink in xm editor. The name of the marker needs to be somewhat included in the name (because we can have multiple ones on same line) but that makes the name long and clumsy.
oups, commented on wrong issue..
Added marker locations for dependency problems
let me explain why I have defined the above mentioned constraints the way I did. 1. <artifactId>XXX</artifactId> is preferred to <plugin> when marking because it's exactly what we want the user to focus his eyes. he can read the id without moving his eyes, gets context instantly. With <plugin> underscored, the user has to scan the text below and parse the artifactId out.. Applies to goals, execution ids and anything else.. 2. the <plugins>, <dependencies>, <build> element is preferred to <parent>because it prevents heaping of all errors in one place. That's likely to become a problem in large projects or when our number of markers increases. It clusters related errors together (eg. everything related to <build>/<plugins> will be close together and one doesn't have to scroll up and down.
Added marker locations for build problems: http://git.eclipse.org/c/m2e/m2e-core.git/commit/?id=ad7b34e03d1cc49f81219a37f50772cff30b21e7 https://github.com/sonatype/m2e-core-tests/commit/6f49233f6de93706018878be659fc64dae1cf4a2
Presently, we have locations for most common markers. There are still some markers that do not have proper locations, but we can handle those on a per need basis.
Moved to https://github.com/eclipse-m2e/m2e-core/issues/
