Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337146 - Git clone wizard hangs if clipboard contains corrupt URI
Summary: Git clone wizard hangs if clipboard contains corrupt URI
Status: RESOLVED WORKSFORME
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.11   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-14 12:21 EST by Jens Baumgart CLA
Modified: 2013-05-11 18:41 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Baumgart CLA 2011-02-14 12:21:31 EST 
Copy a corrupted URI to the clipboard e.g. //git.wdf.sap.corp/egit.git

Start clone wizard from Repositories View. Now the system hangs >10s

Problem: RepositorySelectionPage calls Transport.canHandleProtocol(u, FS.DETECTED) with the given URI from the clipboard.



Thread [main] (Suspended)	
	java.io.WinNTFileSystem.getBooleanAttributes(java.io.File) line: not available [native method]	
	java.io.File.isFile() line: not available	
	org.eclipse.jgit.transport.TransportBundleFile.canHandle(org.eclipse.jgit.transport.URIish, org.eclipse.jgit.util.FS) line: 68	
	org.eclipse.jgit.transport.Transport.canHandleProtocol(org.eclipse.jgit.transport.URIish, org.eclipse.jgit.util.FS) line: 347	
	org.eclipse.egit.ui.internal.components.RepositorySelectionPage.<init>(boolean, java.util.List<org.eclipse.jgit.transport.RemoteConfig>, java.lang.String) line: 332	
	org.eclipse.egit.ui.internal.components.RepositorySelectionPage.<init>(boolean, java.lang.String) line: 372	
	org.eclipse.egit.ui.internal.clone.GitCloneWizard.<init>() line: 77	
	org.eclipse.egit.ui.internal.repository.tree.command.CloneCommand.execute(org.eclipse.core.commands.ExecutionEvent) line: 26
Comment 1 Jens Baumgart CLA 2011-02-14 12:28:20 EST 
Perhaps the URI could be checked before talking to Transport.
Comment 2 Jens Baumgart CLA 2011-02-15 11:35:16 EST 
Problems: 

- check takes long time
- wizard is not up
- user gets no feedback
- not working URI is thrown away without feedback to the user
Comment 3 Matthias Sohn CLA 2013-05-11 18:41:58 EDT 
this works for me with current nightly build without hanging