Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337126 - EMF Facet QuerySet model modification
Summary: EMF Facet QuerySet model modification
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Gregoire Dupe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-14 09:26 EST by Nicolas Guyomar CLA
Modified: 2020-05-01 11:26 EDT (History)
2 users (show)

See Also:
gdupe: indigo+

Attachments
org.eclipse.emf.facet.efacet (55.22 KB, patch)
2011-02-14 09:32 EST, Nicolas Guyomar CLA 		no flags Details | Diff
org.eclipse.emf.facet.efacet (55.29 KB, patch)
2011-02-15 06:07 EST, Nicolas Guyomar CLA 		no flags Details | Diff
Patch for Bug 337126 (57.75 KB, patch)
2011-03-03 12:17 EST, Nicolas Guyomar CLA 		gdupe: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Guyomar CLA 2011-02-14 09:26:53 EST 
Hi,

EMF Facet FacetSet should have an nsUri as well as a reference to the extended meta-model.

Regards,
Nicolas
Comment 1 Nicolas Guyomar CLA 2011-02-14 09:32:04 EST 
Created attachment 188905 [details]
org.eclipse.emf.facet.efacet

Hi,

Please find attached a patch with the required modifications.


(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.


Regards

Nicolas Guyomar
Comment 2 Nicolas Guyomar CLA 2011-02-15 06:07:14 EST 
Created attachment 188985 [details]
org.eclipse.emf.facet.efacet

Updated patch, previous version was corrupted

Regards,
Nicolas Guyomar
Comment 3 Nicolas Guyomar CLA 2011-03-03 11:09:45 EST 
Comment on attachment 188985 [details]
org.eclipse.emf.facet.efacet

Hi,

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.


Regards,
Nicolas Guyomar
Comment 4 Gregoire Dupe CLA 2011-03-03 11:51:45 EST 
Hi,

A facetSet has to be an EPackage and a facet has to be an Eclassifier. Otherwise it will be too difficult to implement the customization tool.

Regards,
Grégoire
Comment 5 Nicolas Guyomar CLA 2011-03-03 12:17:49 EST 
Created attachment 190290 [details]
Patch for Bug 337126

Hi,

Please find attached an updated patch with the required modifications.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.


Regards,
Nicolas Guyomar
Comment 6 Gregoire Dupe CLA 2011-03-14 11:17:06 EDT 
Comment on attachment 190290 [details]
Patch for Bug 337126

Here are a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 394.
Comment 7 Gregoire Dupe CLA 2011-03-14 11:17:42 EDT 
This bug can be marked has fixed.
Comment 8 Gregoire Dupe CLA 2011-06-07 12:24:59 EDT 
This bug can be closed.