Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337116 - Many org.eclipse.core.runtime.CoreExceptions are thrown when decorating .git folder
Summary: Many org.eclipse.core.runtime.CoreExceptions are thrown when decorating .git ...
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Philipp Thun CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 337671 338250 338927 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-14 08:33 EST by CLA
Modified: 2011-03-10 08:14 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description CLA 2011-02-14 08:33:46 EST 
EGit build: 0.12.0.201102120946 but also occurs in earlier 0.11

1. Ensure that in the Package Explorer View "*.resources" are NOT filtered. (i.e you can see files like .project and .classpath in the Package Explorer tree)

2. Create a new Java Project "Foo"

3. Share the Project to Git and create the repo in the wizard.

4. In the Package Explorer View expand the .git folder.

I get hundreds of these:

org.eclipse.core.runtime.CoreException: Resource could not be decorated
	at org.eclipse.egit.ui.internal.decorators.GitLightweightDecorator.prepareDecoration(GitLightweightDecorator.java:314)
	at org.eclipse.egit.ui.internal.decorators.GitLightweightDecorator.processDecoration(GitLightweightDecorator.java:276)
	at org.eclipse.egit.ui.internal.decorators.GitDecoratorJob.run(GitDecoratorJob.java:85)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Comment 1 CLA 2011-02-14 08:39:46 EST 
I forgot one important step after step 2: Expand the "Foo" Project in Package Explorer View so you can see the child nodes.

So the steps are now:

1. Ensure that in the Package Explorer View "*.resources" are NOT filtered.
(i.e you can see files like .project and .classpath in the Package Explorer
tree)

2. Create a new Java Project "Foo"

3. Expand the "Foo" Project in Package Explorer View so you can see the child nodes.

4. Share the Project to Git and create the repo in the wizard.

5. In the Package Explorer View expand the .git folder.
Comment 2 CLA 2011-02-14 08:45:23 EST 
Two issues then:

1. Cannot decorate something in the .git folder if it's visible in Package Explorer.

2. Why are we seeing the .git folder after creating the repo in the Share wizard when the Project is expanded in the tree? (I even have .git added as an Ignored Resource in Team Preferences).
Comment 3 Philipp Thun CLA 2011-02-24 11:01:21 EST 
I have uploaded a change for review (http://egit.eclipse.org/r/2594) that removes these error messages. In general it is normal that resources under .git are not decorated - as these are team private resources. That's why the project explorer automatically hides this directory. I do not know why the package explorer does not do the same. But when you hit F5 on project level the .git folder also vanishes. I think this refreshing issue is a problem of this specifc view.

One additional note: 'ignored resources' means that these resources are not under version control, this setting has no influence on the Eclipse workspace.
Comment 4 CLA 2011-02-24 11:52:05 EST 
(In reply to comment #3)
> ....In general it is normal that resources under .git
> are not decorated - as these are team private resources. That's why the project
> explorer automatically hides this directory. I do not know why the package
> explorer does not do the same.

I see the same behaviour in Project Explorer as well as Package Explorer.
Comment 5 Matthias Sohn CLA 2011-02-25 14:32:19 EST 
*** Bug 337671 has been marked as a duplicate of this bug. ***
Comment 6 Matthias Sohn CLA 2011-02-25 15:38:03 EST 
merged as f0cf09a66e8895dc0c7ac56a15d50d64194e4f0b
Comment 7 Stefan Lay CLA 2011-02-28 08:44:40 EST 
*** Bug 338250 has been marked as a duplicate of this bug. ***
Comment 8 Matthias Sohn CLA 2011-03-10 08:14:20 EST 
*** Bug 338927 has been marked as a duplicate of this bug. ***