Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 337015 - removeListener() method in ModelElement class doesn't handle ImpliedElementProperty
Summary: removeListener() method in ModelElement class doesn't handle ImpliedElementPr...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sapphire (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Shenxue Zhou CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-11 19:15 EST by Shenxue Zhou CLA
Modified: 2021-11-19 09:21 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shenxue Zhou CLA 2011-02-11 19:15:19 EST 
This method in ModelElement class:
    public final void removeListener( final ModelPropertyListener listener,
                                     final ModelPath path )
    
doesn't handle ImpliedElementProperty. See Line 855.
Comment 1 Shenxue Zhou CLA 2011-02-11 19:17:22 EST 
I have a fix for it. Should I just go ahead to check it in?
Comment 2 Konstantin Komissarchik CLA 2011-02-14 16:50:43 EST 
Yes, please fix this.
Comment 3 Shenxue Zhou CLA 2011-02-15 12:18:00 EST 
Fix has been checked in.
Comment 4 Shenxue Zhou CLA 2011-04-01 13:44:37 EDT 
There is another instance of this inside removeListener() under branch of else if( head instanceof AllSiblingsSegment )
Comment 5 Shenxue Zhou CLA 2011-04-01 13:49:11 EDT 
I think I've got all those instances...
Comment 6 Ram Venkataswamy CLA 2011-06-09 16:54:51 EDT 
verified with build 393
Comment 7 Konstantin Komissarchik CLA 2011-06-09 16:55:35 EDT 
Closing.