Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336999 - [Crossfire] update JSDT to use updated Crossfire breakpoints protocol
Summary: [Crossfire] update JSDT to use updated Crossfire breakpoints protocol
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Grant Gayed CLA
QA Contact: Michael Rennie CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-11 14:14 EST by Grant Gayed CLA
Modified: 2011-03-07 15:22 EST (History)
1 user (show)

See Also:


Attachments
patch (19.71 KB, patch)
2011-02-25 13:40 EST, Grant Gayed CLA
no flags Details | Diff
updated breakpoints patch (19.65 KB, text/plain)
2011-03-04 10:39 EST, Grant Gayed CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Grant Gayed CLA 2011-02-11 14:14:28 EST
I'm doing some of this work and will attach a patch with it here in the coming days.
Comment 1 Grant Gayed CLA 2011-02-25 13:40:21 EST
Created attachment 189839 [details]
patch

Michael can you have a look at this patch?  It contains:

- the protocol changes for the setbreakpoint, clearbreakpoint and changebreakpoint requests

- additional changes in support of these, in particular:

  -> when a script's source is retrieved, a persistent property is now set on its file indicating the url it originally came from

  -> when a CFVirtualMachine is created all known JS breakpoints are now sent to the Crossfire server's global breakpoints table

  -> a Map of breakpoint->Crossfire handles is now maintained in CFVirtualMachine

    -> setting these handle values as an attribute on each breakpoint's IMarker would have been nicer, but doing so was triggering marker change notifications, so I fell back to creating the Map instead (maybe triggering the change notifications were fine?)

- NO protocol changes related to getbreakpoint or getbreakpoints as these are not yet being used

- a change completely unrelated to any of this, but too small to log a separate report for: the stepaction for stepping over should be "next", not "over"
Comment 2 Grant Gayed CLA 2011-03-04 10:39:45 EST
Created attachment 190397 [details]
updated breakpoints patch

This updated patch was made a few days ago, after various other JSDT changes were made that caused the original patch in this report no longer apply.
Comment 3 Grant Gayed CLA 2011-03-07 15:22:19 EST
fixed > 20110307