Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336920 - Use structured compare viewer for tree comparisons
Summary: Use structured compare viewer for tree comparisons
Status: ASSIGNED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.11   Edit
Hardware: All All
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Jens Baumgart CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-11 07:11 EST by Alex Blewitt CLA
Modified: 2012-10-17 11:32 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2011-02-11 07:11:45 EST
The EGit 0.11 brings many improvements, but there is no need for a 'git tree compare' view when we can have structured comparison view that allows the tree to be navigated in one go. For example, the 'sycnrhonize' view shows what can be done in a single tree view.

I appreciate that the side-by-side view can be useful for determining renames, but the standard view already handles that and is much more accessible. In addition, it permits you to drill down into the file's contents and do a structured comparison of what has changed at the class level (in the case of a Java class) and see what methods/functions have been removed and replaced.

The two-pane view might be useful in some circumstances but it's not taking advantage of the Eclipse structured comparator view.
Comment 1 Alex Blewitt CLA 2011-02-11 07:16:14 EST
This is against EGit 0.11; for some reason, Mylyn isn't showing me that in the versions drop-down list. (I suspect it's cached the values from before and will pick up later.)
Comment 2 Robin Stocker CLA 2012-02-28 13:41:29 EST
Is this still the case? Doesn't "Compare with Each Other" in History View provide a structural compare view?
Comment 3 Jens Rutschmann CLA 2012-10-17 11:32:29 EDT
(In reply to comment #2)
> Is this still the case? Doesn't "Compare with Each Other" in History View
> provide a structural compare view?

The History view provides indeed a structural compare view.

But at least when I do <Package Explorer Context Menu> -> 'Compare With' -> 'HEAD Revision' it opens the 'Git Tree Compare'. Shouldn't this open the same compare view as from the History View ?

This happens with Eclipse 3.7.2 and EGit 2.1.0