Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336847 - [tracepoint] Tracepoints cannot be set from the Disassembly view
Summary: [tracepoint] Tracepoints cannot be set from the Disassembly view
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 7.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 7.0.2   Edit
Assignee: Marc Khouzam CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-10 12:14 EST by Marc Khouzam CLA
Modified: 2011-02-11 05:18 EST (History)
3 users (show)

See Also:
aleherb+eclipse: review+

Attachments
Fix (1.13 KB, patch)
2011-02-10 12:14 EST, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2011-02-10 12:14:17 EST 
Created attachment 188703 [details]
Fix

I just realized that from the very start, it has not been possible to set tracepoints from the Disassembly view due to a screw-up of my commit for Tracepoints' first patch, where the fix attached here was forgotten (bug 284286).

Here is the fix.
Comment 1 Marc Khouzam CLA 2011-02-10 12:21:34 EST 
Committed to HEAD and 7_0

Toni can you review?
Comment 2 CDT Genie CLA 2011-02-10 12:22:35 EST 
*** cdt cvs genie on behalf of mkhouzam ***
Bug 336847: Tracepoints cannot be set from the Disassembly view

[*] plugin.xml 1.42 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/plugin.xml?root=Tools_Project&r1=1.41&r2=1.42
Comment 3 CDT Genie CLA 2011-02-10 13:22:35 EST 
*** cdt cvs genie on behalf of mkhouzam ***
Bug 336847: Tracepoints cannot be set from the Disassembly view

[*] plugin.xml 1.38.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/plugin.xml?root=Tools_Project&r1=1.38&r2=1.38.2.1
Comment 4 Anton Leherbauer CLA 2011-02-11 05:18:40 EST 
+1 Looks good.