Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336825 - Use Modules2.mixin() in Activators
Summary: Use Modules2.mixin() in Activators
Status: CLOSED WORKSFORME
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 1.0.1   Edit
Hardware: Macintosh Mac OS X
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-10 09:29 EST by Karsten Thoms CLA
Modified: 2017-09-19 18:17 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karsten Thoms CLA 2011-02-10 09:29:02 EST 
In the UI Activator class the injector is created using Module.override() like this

				Modules.override(Modules.override(getRuntimeModule("x.y.z.MyDsl")).with(getUiModule("x.y.z.MyDsl"))).with(getSharedStateModule())

The code would be better readable if Modules2.mixin() is used:

				Modules2.mixin(getRuntimeModule("x.y.z.MyDsl"), getUiModule("x.y.z.MyDsl"), getSharedStateModule())
Comment 1 Sven Efftinge CLA 2011-03-26 15:32:37 EDT 
Sorry, but this is not worth any effort.
Comment 2 Karsten Thoms CLA 2017-09-19 18:08:27 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 3 Karsten Thoms CLA 2017-09-19 18:17:54 EDT 
Closing all bugs that were set to RESOLVED before Neon.0