Community
Participate
Working Groups
Build Identifier: The Eclipse Color Theme plugin (currently quite popular on the Eclipse Marketplace) adds color themes to Eclipse. Jacek Pospychala has approached us, asking whether we would like to integrate a modified version of the plugin into PDT, and we would be happy to contribute what we have. The attached source code is the current stable release of the plugin. We will have to do some small changes in order to make it work well within PDT: - Remove all non-PHP related editor mappings (Java, C++, ...) - Make it possible for the full ECT plugin to "overwrite" the functionality bundled with PDT Reproducible: Always
Created attachment 188545 [details] The source code of Eclipse Color Theme version 0.8.0.
Yay! Thanks Felix and Roger! Let's try to get it into Eclipse Indigo release.
I have opened CQ4890 (http://dev.eclipse.org/ipzilla/show_bug.cgi?id=4890) for this contribution and waiting with my whole heart to see it approved as soon as possible. (btw. the link to CQ may be unaccessible, because it requires eclipse staff or committer login, but I'll keep you posted about any updates)
I've got a follow-up from Sharon Corbett <sharon.corbett@eclipse.org> >Can you please arrange for Felix and Roger to make the following individual >confirmations via the referenced bug: > >Confirmations: >1. I authored 100% of the content I am contributing >2. I have the rights to contribute the content to Eclipse >3. I contribute the content under the EPL > > >We will also need to understand if they accepted any community contributions to >the code base. Depending on their answer I could have follow on questions. > >Please let me know when they have made the necessary statements. > >Kind Regards, >Sharon Felix, Roger, could you confirm all the above in this bug?
1. Yes, I authored 100% of the content I am contributing 2. Yes, I have the rights to contribute the content to Eclipse 3. I agree to contribute the content under the EPL The color codes used in the theme XML files are contributed from the community using an online editor on eclipsecolorthemes.org under the CC BY-SA 3.0 license.
(In reply to comment #4) >Confirmations: >1. I authored 100% of the content I am contributing >2. I have the rights to contribute the content to Eclipse >3. I contribute the content under the EPL Yes to all of this, from my side, but here are some remarks: To 1.: There have been two small pull requests on GitHub, although I heavily modified them in both cases. I assume that, since our code has always been under the EPL, all contributions are derived versions and hence automatically licensed under the same conditions. To 3.: The colour themes included with the plugin are licensed under the CC-BY-SA creative commons license.
Thanks!
Created attachment 188959 [details] The source code of Eclipse Color Theme version 0.9.0. As discussed via email, I've added the source code of version 0.9 of ECT which we just released.
Created attachment 188974 [details] The source code of Eclipse Color Theme version 0.9.1. We've just fixed a bug in version 0.9, so I attached the altered source code. Only a few lines have changed.
5 year later and nothing happens. We have CQ for color theme and it's not used (it ever was?). Team, have we plan to try again, or mark as WONTFIX. Especially in marketplace era. Personally I think that if color theme plugin should be ever integrated with Eclipse / PDT, better place will be Platform UI.
I agree, this plugin should be part of platform not PDT. WONTFIX for me.
Closing
