Community
Participate
Working Groups
Created attachment 188528 [details] Proxy support for Usage Data Collector The current implementation of the Usage Data Collector does not support proxies. The attached patch sets relevant proxies (from org.eclipse.core.net.proxy) for usage data uploads. To properly set the Content-Length header (required by some proxies) I needed to filter the uploads into temporary files which are also used as the upload source (to avoid duplicate filtering).
Targeting 1.4.0 M6. Thanks for the contribution.
Did you have the opportunity to look at this for M6?
I'm trying to grok the changes to BasicUploader. I really liked that FilteredFilePart stuff. How much of the ProxyHelper comes directly from the ECF implementation? For tracking purposes, it would be helpful if you could separate the contribution into separate patches: one for the ProxyHelper and one for the rest. Also, can you please assert that you authored these changes and conscent to them being distributed under the terms of the EPL?
I authored the changes and consent to them being provided under the EPL. The difficulty I had with FilteredFilePart was the proxy that I used for testing (Squid) requires an accurate Content-Length header, but when the filtering is performed during the transfer the length of the upload isn't known until after the headers are sent. In ProxyHelper getProxy, getSocksProxy and selectProxyFromProxies are in the original class, I altered them to remove ECF specific code. setupProxies is modified from org.eclipse.ecf.provider.filetransfer.httpclient.HttpClientRetrieveFileTransfer For the two patches, do they need to be able to be applied separately and still compile?
ping.
If you give us commit right, we could apply the patch :)
I've gotten the same problem with the UDC. Others reported this in Bug 340567 and Bug 241511 (which is closed). However, it might not matter, because according to Bug 347069, the UDC will be removed from Eclipse Juno.
*** Bug 367402 has been marked as a duplicate of this bug. ***
The Usage Data Collector was decommissioned a long time ago. Therefore any remaining bugs are now being closed as WONTFIX. If this bug is still relevant, please make a comment and we'll move it to the correct project/component for further investigation. This change was made as part of a bulk change.
