Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336613 - [Compatibility] View toolbar not updated after opening a local shell in TM
Summary: [Compatibility] View toolbar not updated after opening a local shell in TM
Status: NEW
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: dsdp.tm.rse-inbox CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331440
  Show dependency tree
 
Reported: 2011-02-08 08:33 EST by Remy Suen CLA
Modified: 2012-01-16 16:24 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-02-08 08:33:31 EST
1. Open the 'Remote Shell' view.
2. View menu > Launch > Local
3. The terminal appears but then the view menu disappears. Activating another view in the same stack and then going back to the 'Remote Shell' view will bring it back.
Comment 1 Remy Suen CLA 2011-02-08 09:22:24 EST
Asking the tool bar manager to update itself will cause the problem.

getViewSite().getActionBars().getToolBarManager().update(true);
Comment 2 Remy Suen CLA 2011-05-16 09:42:30 EDT
Still a problem on I20110515-0800. It seems to be a layout problem as forcing a resize of the view will fix the problem.
Comment 3 Eric Moffatt CLA 2011-05-25 08:50:15 EDT
Is it possible that this is another view that needs a forced 'resize' message to be sent to it (like the Debug view) ?
Comment 4 Remy Suen CLA 2011-05-25 08:53:01 EDT
(In reply to comment #3)
> Is it possible that this is another view that needs a forced 'resize' message
> to be sent to it (like the Debug view) ?

Unlikely as this is the view's tool bar and not the view itself.
Comment 5 Remy Suen CLA 2011-05-25 13:17:11 EDT
Still broken on I20110524-1000 so it doesn't look like the recent changes affected this scenario.
Comment 6 Remy Suen CLA 2011-09-29 16:39:46 EDT
The menu doesn't disappear but the view's toolbar doesn't update itself. You need to force a layout for its new items to show up in the toolbar.
Comment 7 Remy Suen CLA 2011-09-29 16:57:31 EDT
Broken on I20110916-1615 but may be fixed with by the changes for bug 344832.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=66bc52ad4fb39acfd11c1f53dcde24aac3c57db0

I'll take a closer look.
Comment 8 Remy Suen CLA 2011-09-30 08:56:50 EDT
(In reply to comment #7)
> Broken on I20110916-1615 but may be fixed with by the changes for bug 344832.
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=66bc52ad4fb39acfd11c1f53dcde24aac3c57db0

Negative. Still broken on I20110927-2000.
Comment 9 Remy Suen CLA 2011-09-30 09:31:53 EDT
(In reply to comment #1)
> Asking the tool bar manager to update itself will cause the problem.

Please call updateActionBars() to propagate the change to the workbench instead of just having the manager update.
Comment 10 Martin Oberhuber CLA 2011-10-03 03:41:38 EDT
(In reply to comment #9)
> Please call updateActionBars() to propagate the change to the workbench instead
> of just having the manager update.

So... are you saying that we didn't use API properly, and updating to 4.2 exposes our misbehavior ?

Or is there a regression in terms of functionality between 3.x and 4.2 which you're asking us to work around ?
Comment 11 Remy Suen CLA 2011-10-03 09:15:47 EDT
(In reply to comment #10)
> So... are you saying that we didn't use API properly, and updating to 4.2
> exposes our misbehavior ?

This is the current scenario as I understand it. I will check with Paul to be sure, you can hold off making any changes in the meantime if desired.
Comment 12 Remy Suen CLA 2011-10-03 10:19:49 EDT
(In reply to comment #11)
> I will check with Paul to be
> sure, you can hold off making any changes in the meantime if desired.

<rcjsuen> paulweb515_: If someone updates a view's toolbar manager, they _must_ call updateActionBars() instead of just calling tbm.update(boolean), correct?
<paulweb515_> rcjsuen: if they got it from getActionBars(), yes
<paulweb515_> but that's mostly to handle additions/subtractions ... changing the tooltip should work
<rcjsuen> they're adding items
Comment 13 Remy Suen CLA 2012-01-16 16:24:15 EST
I installed RSE today and this is still broken. Though I admit that these build identifiers look a little suspicious. Is there supposed to be something newer on the Juno update site?

Remote System Explorer End-User Runtime
3.3.1.R33x_v201109141647-7L7CFGG8wqio8rz0qYtkPgn8qWd4
Remote System Explorer User Actions
1.1.300.v201103142315-31F8N8s7355353B75DD