Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336482 - KeyBinding to edit element in Table : F2
Summary: KeyBinding to edit element in Table : F2
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P4 normal (vote)
Target Milestone: ---   Edit
Assignee: Gregoire Dupe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 335020
Blocks:
  Show dependency tree
 
Reported: 2011-02-07 04:43 EST by Vincent Lorenzo CLA
Modified: 2020-05-01 11:27 EDT (History)
0 users

See Also:
gdupe: indigo+

Attachments
Patch for Bug 336482 (8.02 KB, patch)
2011-03-29 09:18 EDT, Nicolas Guyomar CLA 		gdupe: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Lorenzo CLA 2011-02-07 04:43:41 EST 
The keybinding should be done using org.eclipse.ui.binding. 
In order to do that : 
	- a org.eclipse.ui.commands should be defined for the edition
	- I think a context for the binding should be defined (org.eclipse.ui.context) too.
Comment 1 Vincent Lorenzo CLA 2011-02-07 04:58:21 EST 
I saw the command for edition already exists in Eclipse : org.eclipse.ui.edit.rename
You should provide an Handler to this command and the binding will be correctly defined.
Comment 2 Nicolas Guyomar CLA 2011-03-29 09:18:59 EDT 
Created attachment 192086 [details]
Patch for Bug 336482

Hi Vincent,

I've added an handler on org.eclipse.ui.edit.rename and plugged it on NatTableWidget

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar
Comment 3 Gregoire Dupe CLA 2011-03-30 04:08:15 EDT 
Comment on attachment 192086 [details]
Patch for Bug 336482

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 475.
Comment 4 Gregoire Dupe CLA 2011-03-30 04:08:51 EDT 
This bug can be marked as fixed.
Comment 5 Vincent Lorenzo CLA 2011-04-06 03:24:50 EDT 
This bug can be closed.
Comment 6 Vincent Lorenzo CLA 2011-09-15 09:06:52 EDT 
As I said, this bug can be closed.