Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336441 - Extraneous menu and tool bar items after installing modeling component
Summary: Extraneous menu and tool bar items after installing modeling component
Status: RESOLVED WONTFIX
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Cross-Project (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Cross-Project issues CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-05 23:39 EST by David Williams CLA
Modified: 2018-04-16 10:12 EDT (History)
7 users (show)

See Also:


Attachments
EFT Test picture (161.50 KB, image/png)
2011-02-05 23:40 EST, David Williams CLA
no flags Details
Diagram Services Samples picture (163.73 KB, image/png)
2011-02-05 23:40 EST, David Williams CLA
no flags Details
install modeling components item (211.96 KB, image/png)
2011-02-05 23:41 EST, David Williams CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2011-02-05 23:39:31 EST
This can probably be moved to modeling component, but thought I'd start off here, since some issue might effect everyone, and was from my testing of Indigo M5 repo. 

I tried installing whole "modeling category" and while normally we don't recommend such things, it does provide a good test :) 

The most obvious problem was "EFS Test" menu item and tool bar item. Obviously left in as some sort of test ... but, shouldn't be there in milestone quality code, IMHO. 

Next oddity, to me, was a "Diagram Services Samples" menu. Seems to me that "samples and examples" should not appear on main menu bar. I do not know what to recommend for all cases, but some are under "new projects/examples" some on welcome screens. But, seems intrusive to put them on main menu bar simply by installing a plugin. IMHO. 

Lastly, perhaps the topic for most general discussion is that someone, in Modeling category, adds a tool bar item and Help menu choice to "Install Modeling Components". This seems wrong for several reason, but most of all, why have a new, alternative method? Isn't that just clutter (for most users). If "Install new software" does not suffice, then perhaps "Eclipse market place" is an alternative to find these components to install?
Comment 1 David Williams CLA 2011-02-05 23:40:14 EST
Created attachment 188397 [details]
EFT Test picture
Comment 2 David Williams CLA 2011-02-05 23:40:43 EST
Created attachment 188398 [details]
Diagram Services Samples picture
Comment 3 David Williams CLA 2011-02-05 23:41:16 EST
Created attachment 188399 [details]
install modeling components item
Comment 4 Stephan Herrmann CLA 2011-02-06 06:40:30 EST
(In reply to comment #0)
> [...]
> Lastly, perhaps the topic for most general discussion is that someone, in
> Modeling category, adds a tool bar item and Help menu choice to "Install
> Modeling Components". This seems wrong for several reason, but most of all, why
> have a new, alternative method? Isn't that just clutter (for most users). If
> "Install new software" does not suffice, then perhaps "Eclipse market place" is
> an alternative to find these components to install?

Sure all these menu items are related, but from my understanding 
"Install Modeling Components" is different from market place as it stays 
within the Eclipse.org repositories, whereas market place brings the whole
wealth of plug-ins provided anywhere on the globe.

Naively thinking this seems to call for some sub-menu structure. E.g.:

Help
  Install new software ...
    Configured Software Sites       // the plain p2 UI
    Catalogues ...
      Eclipse Market Place
      Modeling Components
      Mylyn Connectors
      Subversive Connectors
      ...

Similar considerations might hold for:
Help
  Feedback ...
    Report Maven Issue
    Subversive ...
      Send X
      Send Y
Comment 5 Eike Stepper CLA 2011-02-06 07:38:10 EST
(In reply to comment #4)
> Sure all these menu items are related, but from my understanding 
> "Install Modeling Components" is different from market place as it stays 
> within the Eclipse.org repositories, [...]

IIRC Cedric Brun told me I could also discover components outside Eclipse.org with the Modeling Discovery.
Comment 6 Anthony Hunter CLA 2011-02-07 09:51:47 EST
(In reply to comment #0)
> Next oddity, to me, was a "Diagram Services Samples" menu. Seems to me that
> "samples and examples" should not appear on main menu bar. I do not know what
> to recommend for all cases, but some are under "new projects/examples" some on
> welcome screens. But, seems intrusive to put them on main menu bar simply by
> installing a plugin. IMHO. 

The diagrams services samples comes from installing the GMF Runtime Examples. This menu has actually always been in the examples, so I am not sure we want to "remove" it.

I think the actual issue is the inclusion of the examples in the Indigo repo (like we did for Helios).

If the "Diagram Services Samples" menu is intrusive after you do an "Install ALL", perhaps we should reconsider removing the GMF Runtime examples from the repo.
Comment 7 Doug Schaefer CLA 2011-02-07 10:04:10 EST
BTW, Big thanks David for taking this initiative. Interop testing has always been much needed and these issues need to be brought to the community's attention.

We have to assume a lot of people end up installing the entire repo. It needs to be treated as a valid use case. If there are plug-ins that make this difficult or the resulting installation hard to use, then we should remove those plug-ins or clean them up. Example and test plug-ins probably fit into that category.
Comment 8 David Williams CLA 2011-02-07 10:10:28 EST
> 
> If the "Diagram Services Samples" menu is intrusive after you do an "Install
> ALL", perhaps we should reconsider removing the GMF Runtime examples from the
> repo.

I should emphasize ... I was just documenting things that looked a little odd
or misplaced to me. Sort of a quick "first impression". No one should jump
though hoops based _solely_ on what looks odd to me ... but, I appreciate the
consideration of alternatives. To have such samples elsewhere, perhaps
separately installable might be a good alternative ... but, hard for me to
know. Is there anything in our "UI Guidelines" that help specify how to handle
samples and examples consistently? (If not, there should be :)  My only desire
is we end up looking like a professional IDE ... but, within that, I know
there's lots of differences of opinions. Also, blindly "installing everything"
is certainly one use-case, but not necessarily the only one, and perhaps if people deliberately selected "GMF Runtime examples" then these "extra" items are exactly what they'd expect. 

Again, hard for me to know. Appreciate the extra care. And others opinions and views.
Comment 9 David Williams CLA 2011-02-07 10:17:26 EST
(In reply to comment #5)
> (In reply to comment #4)
> > Sure all these menu items are related, but from my understanding 
> > "Install Modeling Components" is different from market place as it stays 
> > within the Eclipse.org repositories, [...]
> 
> IIRC Cedric Brun told me I could also discover components outside Eclipse.org
> with the Modeling Discovery.

My concern here is that we have so many "install" options. I suspect there is a desire to "advertise" right directly from the "help" menu ... but that's obviously not scalable, right? Seems if the "Install new Software" and "Eclipse Market Place" are not sufficient, then something is wrong with those options, and my wish (my unfunded with :) would be that those common mechanisms could be improved to satisfy what's needed. If, on the other hand, the only desire is to advertise any one specific project over another ... then I do not then that is justifiable in an "install everything" sort of scenerio. Maybe it would be though, in the EPP Modeling package? Maybe that's an alternative if you really feel a need for a specific "install modeling components" option? Just an idea.
Comment 10 Martin Oberhuber CLA 2011-02-07 10:56:25 EST
Regarding Samples specifically.... The JDT samples can be installed from the JDT Intro contribution (Help > Welcome > Samples).

I think that's a good way of dealing with samples, since such an "install samples" wizard is not only located where it's expected, it also allows keeping the samples repo separate from the main repo.
Comment 11 Cedric Brun CLA 2011-02-15 04:25:27 EST
(In reply to comment #5)
> (In reply to comment #4)
> > Sure all these menu items are related, but from my understanding 
> > "Install Modeling Components" is different from market place as it stays 
> > within the Eclipse.org repositories, [...]
> 
> IIRC Cedric Brun told me I could also discover components outside Eclipse.org
> with the Modeling Discovery.

For the sake of clarification, the Modeling Discovery is here to enable the discovery  of all the great components the Eclipse Modeling project provides. 

It has been done this way to keep a usable bundle (not including everything by default) and to help projects promote themselves.

So yes, it's restricted to Eclipse Modeling project. That said, some project sometime needs complementary features to provide the best user experience which can't be hosted on Eclipse.org for IP reasons : xText/ANTLR for instance, AMP and it's 3D layer. In those cases the discovery entry might be extended to install by default those extra features and the end user is warned using a specific notice.
Comment 12 Eclipse Genie CLA 2014-05-04 15:46:54 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 13 Eclipse Genie CLA 2016-04-24 08:51:20 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 14 Eclipse Genie CLA 2018-04-15 05:59:47 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.