Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336409 - Refine error handling of exception caught at IQuery#close method
Summary: Refine error handling of exception caught at IQuery#close method
Status: RESOLVED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: Open Data Access (show other bugs)
Version: 1.8.1   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 1.8.2   Edit
Assignee: Linda Chan CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-04 21:38 EST by Linda Chan CLA
Modified: 2011-03-14 20:06 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Linda Chan CLA 2011-02-04 21:38:26 EST
When calling an ODA driver's implementation of IQuery#close method, if the ODA driver throws an exception, the ODA consumer framework currently handles it as a severe error.  However, an error at #close may be safely ignored by a consumer application depending on the driver-specific implementation. 
It would be more robust to refine the error handling to proceed and handle such case as a warning instead.
Comment 1 Linda Chan CLA 2011-02-04 22:13:27 EST
As a consumer application may ignore the exception thrown by IQuery#close method implementation, the odaconsumer framework now handles it as a warning.
In addition, an UnsupportedOperationException caught by the odaconsumer framework is now logged at the Warning level, instead of Severe level.
Comment 2 Lin Zhu CLA 2011-03-14 20:06:47 EDT
Add new configuration setting so that we can now tailor the JDBC driver to suppress not important SQL exceptions, say, the exception thrown during the close of a Statement/Connection.