Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336392 - Syntax coloring restore default only restore current element
Summary: Syntax coloring restore default only restore current element
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 1.0.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-04 14:46 EST by Samantha Chan CLA
Modified: 2017-09-19 18:01 EDT (History)
4 users (show)

See Also:
sven.efftinge: indigo+

Attachments
proposed patch (2.87 KB, patch)
2011-04-05 13:08 EDT, Michael Clay CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samantha Chan CLA 2011-02-04 14:46:30 EST 
In syntax coloring page, modify syntax coloring for several element types. Click Ok.

Go back in and click Restore Defaults button, only the selected element has its default restored. 

This is not consistent with other syntax coloring preference page, like JDT.  In JDT, restore default will restore default for all elements.
Comment 1 Michael Clay CLA 2011-04-05 13:08:00 EDT 
Created attachment 192579 [details]
proposed patch

pls also check against any pde api tooling warnings/errors
Comment 2 Sven Efftinge CLA 2011-04-05 14:43:30 EDT 
Do you use PDE tooling already?
The patch looks good (if it fixes the problem ;-))
Please apply and push.
Comment 3 Sebastian Zarnekow CLA 2011-04-11 11:41:23 EDT 
Michael, do you have the time to apply and push the attached patch?
Comment 4 Michael Clay CLA 2011-04-11 13:41:49 EDT 
pushed to master
Comment 5 Karsten Thoms CLA 2017-09-19 17:50:36 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 6 Karsten Thoms CLA 2017-09-19 18:01:27 EDT 
Closing all bugs that were set to RESOLVED before Neon.0