Description John Arthorne 2011-02-04 10:56:48 EST

3.7 M5

Given this code:

	for (int i = 0; i < 10; i++) {
		doSomething(expensiveMethod());
	}

If I select "expensiveMethod()" and perform extract local variable I get:

	for (int i = 0; i < 10; i++) {
		String expensiveMethod = expensiveMethod();
		doSomething(expensiveMethod);
	}

However since expensiveMethod is not influenced by i, it would be more efficient as:

	String expensiveMethod = expensiveMethod();
	for (int i = 0; i < 10; i++) {
		doSomething(expensiveMethod);
	}

Note if there are calls to expensiveMethod outside the for loop, then it will correctly place the local variable outside the loop.