Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336347 - Memory Improvement: Share session log between SDOHelperContexts
Summary: Memory Improvement: Share session log between SDOHelperContexts
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-04 09:35 EST by Blaise Doughan CLA
Modified: 2022-06-09 10:34 EDT (History)
1 user (show)

See Also:

Attachments
Proposed fix. (6.80 KB, patch)
2011-02-14 16:08 EST, David McCann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Blaise Doughan CLA 2011-02-04 09:35:00 EST 
Currently each SDOHelperContext has its own session log.  By default each SDOHelperContext should share the same one.
Comment 1 David McCann CLA 2011-02-14 14:03:01 EST 
Each Session has an instance of DefaultSessionLog that we do not use in SDO.  Any logging we currently do is done via the abstract session's singleton default log.  We may be able to:

1) Modify abstract session to enable nulling out the default log for each session, i.e. modify setSessionLog to handle a null input arg.  This will be tricky because each session is expected to have a defult log set and there are plenty of spots where it is lazy loaded.

2) Create a new log, say 'NullSessionLog', that we can set on the session - this log will do nothing when it is asked to log.  Not sure how difficult this will be, but seems like it could work.
Comment 2 David McCann CLA 2011-02-14 16:08:05 EST 
Created attachment 188955 [details]
Proposed fix.

Lazy loaded static NullSessionLog instance on AbstractSessionLog.  In XMLContext constructor instead of calling session.setLogLevel(Session.OFF), we call session.setSessionLog(AbstractSession.getNullSessionLog()).
Comment 3 Eclipse Webmaster CLA 2022-06-09 10:34:12 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink