Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336326 - SWTException when selecting Differencing Engine
Summary: SWTException when selecting Differencing Engine
Status: CLOSED FIXED
Alias: None
Product: EMFCompare
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: EMF Compare CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-04 05:01 EST by aurelien.mariage CLA
Modified: 2011-03-10 04:42 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description aurelien.mariage CLA 2011-02-04 05:01:25 EST 
Build Identifier: 20100917-0705

A SWTException is raised when I add a new DiffEngine thanks to the plugin extension, that seems to be thrown by VisualEngineSelector.

> org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException)
	at org.eclipse.swt.SWT.error(SWT.java:4083)
....
Caused by: java.lang.NullPointerException
	at org.eclipse.emf.compare.ui.internal.VisualEngineSelector$EngineDescriptorLabelProvider.getImage(VisualEngineSelector.java:141)
...

In the file plugin.xml contained in the package org.eclipse.emf.compare.diff, the icon filepath references a non existing file(icons/DiffEngine.gif). Thus, when the selector try to get the image, it crashes ...


Reproducible: Always

Steps to Reproduce:
1. Add a new DiffEngine component thanks to org.eclipse.emf.compare.diff.engine extension point
2. Run a comparison > the diff window displays nothing
Comment 1 Laurent Goubet CLA 2011-03-10 04:42:33 EST 
Hi,

This is due to us having set the icon as "optional" ... while coding as if it were required. The icon is now really optional :). The fix will be available in 1.2.0M6.