Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336320 - [Net4J] Server can't open channel
Summary: [Net4J] Server can't open channel
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.net4j (show other bugs)
Version: 4.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Caspar D. CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-04 03:16 EST by Caspar D. CLA
Modified: 2011-06-23 03:41 EDT (History)
1 user (show)

See Also:
stepper: review+

Attachments
Patch (623 bytes, patch)
2011-02-04 03:18 EST, Caspar D. CLA 		no flags Details | Diff
Patch v2 (3.52 KB, patch)
2011-02-04 04:00 EST, Eike Stepper CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caspar D. CLA 2011-02-04 03:16:54 EST 
When a Net4J server opens a channel, the channel ID will be
negative (i.e. < 0) value. During channel registration,
assertValidChannelID gets called, which will throw an
IllegalArgEx because it erroneously assumes the channel ID
will always be a positive value.
Comment 1 Caspar D. CLA 2011-02-04 03:18:19 EST 
Created attachment 188295 [details]
Patch
Comment 2 Eike Stepper CLA 2011-02-04 04:00:46 EST 
Created attachment 188298 [details]
Patch v2

I changed some of these channel ID constants in several classes. Please review carefully and commit if you are happy with it ;-)
Comment 3 Caspar D. CLA 2011-02-04 05:03:18 EST 
Committed to trunk, rev. 7018
Comment 4 Eike Stepper CLA 2011-06-23 03:41:04 EDT 
Available in R20110608-1407