Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336314 - Partial commits choke on CDOMoveFeatureDeltas
Summary: Partial commits choke on CDOMoveFeatureDeltas
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Caspar D. CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-04 01:57 EST by Caspar D. CLA
Modified: 2011-06-23 03:41 EDT (History)
1 user (show)

See Also:
stepper: review+

Attachments
Testcase (as patch) (3.46 KB, patch)
2011-02-04 02:01 EST, Caspar D. CLA 		no flags Details | Diff
Patch (including testcase) (4.66 KB, patch)
2011-02-04 02:12 EST, Caspar D. CLA 		no flags Details | Diff
Patch v2 (5.37 KB, patch)
2011-02-04 03:13 EST, Eike Stepper CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caspar D. CLA 2011-02-04 01:57:56 EST 
The logic in CommitIntegrityCheck.checkFeatureDelta doesn't
expect to encounter a CDOMoveFeatureDelta. When it does,
it throws a runtime ex.
Comment 1 Caspar D. CLA 2011-02-04 02:01:19 EST 
Created attachment 188292 [details]
Testcase (as patch)
Comment 2 Caspar D. CLA 2011-02-04 02:12:26 EST 
Created attachment 188293 [details]
Patch (including testcase)
Comment 3 Caspar D. CLA 2011-02-04 02:14:13 EST 
Forgot to include the test in the suite.. Will add that change
on approval.
Comment 4 Eike Stepper CLA 2011-02-04 03:13:57 EST 
Created attachment 188294 [details]
Patch v2

Changed the RuntimeException into an IllegalArgumentException and added to AllConfigs. Please commit.
Comment 5 Caspar D. CLA 2011-02-04 05:06:43 EST 
Committed to trunk, rev. 7019
Comment 6 Eike Stepper CLA 2011-06-23 03:41:26 EDT 
Available in R20110608-1407