Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336271 - JUnit fixes for defect verifications tests test311542 and test120018
Summary: JUnit fixes for defect verifications tests test311542 and test120018
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Roberto Sanchez Herrera CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-03 13:49 EST by Roberto Sanchez Herrera CLA
Modified: 2011-02-06 17:16 EST (History)
2 users (show)

See Also:
david_williams: pmc_approved+
ccc: pmc_approved? (raghunathan.srinivasan)
ccc: pmc_approved? (naci.dai)
deboer: pmc_approved+
ccc: pmc_approved? (neil.hauge)
ccc: pmc_approved? (kaloyan)
cbridgha: review+

Attachments
Patch for fixing JUnits (2.58 KB, patch)
2011-02-03 13:52 EST, Roberto Sanchez Herrera CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roberto Sanchez Herrera CLA 2011-02-03 13:49:17 EST 
Build Identifier: WTP M-3.2.3-20110127202034

The Defect Verification Tests test311542 and test120018 failed in the latest WTP build.

For test311542, looks like the getWarFile() is still failing. Note that I could not see this test failing locally, but looks like the getWarFile() should use HeadlessTestsPlugin to get the path of the WAR used for testing.

For test120018, looks like it is a timing issue (this test fails sometimes): this test forces the Classpath container to update and right after that, it verifies that some classes are included in the classpath (and the classpath container might take a little more time to be updated)

Reproducible: Sometimes
Comment 1 Roberto Sanchez Herrera CLA 2011-02-03 13:52:31 EST 
Created attachment 188264 [details]
Patch for fixing JUnits
Comment 2 Chuck Bridgham CLA 2011-02-03 14:31:06 EST 
We added a call to wait for jobs because in normal workspace/ UI
the locks will handle.
Comment 3 Carl Anderson CLA 2011-02-03 17:14:19 EST 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.

We need to get our JUnits working properly for WTP 3.2.3's release.

* Is there a work-around? If so, why do you believe the work-around is insufficient?

No workaround.

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added?

The fix is for JUnit tests only.  They have been run locally.

* Give a brief technical overview. Who has reviewed this fix?

The initial description has a technical overview.  Chuck Bridgham and Carl Anderson have reviewed this fix. 

* What is the risk associated with this fix? 
No risk- this is a change to the JUnits only.
Comment 4 Carl Anderson CLA 2011-02-03 19:59:23 EST 
As per the Q&A section of http://wiki.eclipse.org/WTP_PMC_Defect_Review , this change was released to the respin of RC3 of WTP 3.2.3.